OCPBUGS-70172: Assisted Installer OVE UI shows transient blank page with Technology …

[ElayAharoni]

https://issues.redhat.com/browse/OCPBUGS-70172

Summary by CodeRabbit

• New Features

  • Added single-cluster mode support with automatic infrastructure environment detection and simplified configuration workflow.

• Bug Fixes

  • Improved error handling to prevent clusterId validation errors when operating in single-cluster mode.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[openshift-ci-robot]

@ElayAharoni: This pull request references Jira Issue OCPBUGS-70172, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70172

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified error handling and cache lookup logic in InfraEnv retrieval to conditionally bypass missing-clusterId errors and immediately return the first infraEnv when single-cluster mode is enabled via the SINGLE_CLUSTER feature flag.

Changes

Cohort / File(s)	Summary
Single-Cluster Feature Flag Integration libs/ui-lib/lib/ocm/hooks/useInfraEnvId.ts, libs/ui-lib/lib/ocm/services/InfraEnvsService.ts	Error for missing clusterId now gated by feature flag check; missing-clusterId error only triggers when SINGLE_CLUSTER flag is disabled. InfraEnvsService.getInfraEnvId returns first infraEnv id immediately when flag is enabled; otherwise proceeds with cache update flow. Dependency array updated to include feature flag.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

• #3244: Modifies the same code paths in useInfraEnvId and InfraEnvsService to change InfraEnv lookup behavior when ASSISTED_INSTALLER_SINGLE_CLUSTER_FEATURE is enabled.

Suggested labels

lgtm, approved, size/M

Suggested reviewers

• rawagner

Poem

🐰 A single cluster hops with glee,
No more clusterId errors to see!
The feature flag guides our way,
Infraenvs returned—hip hooray!

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title references a Jira issue (OCPBUGS-70172) and mentions the core problem being fixed, but is truncated and doesn't clearly convey the technical solution of gating infraEnvId errors with the SINGLE_CLUSTER feature flag.

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b9ba48 and 074077f.

📒 Files selected for processing (2)

• libs/ui-lib/lib/ocm/hooks/useInfraEnvId.ts
• libs/ui-lib/lib/ocm/services/InfraEnvsService.ts

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/networkConfigurationValidation.ts:69-69
Timestamp: 2025-10-19T17:22:52.502Z
Learning: CIM UI changes in the repository openshift-assisted/assisted-installer-ui (e.g., files under libs/ui-lib/lib/cim/) are handled separately by the CIM team and should be tracked via separate issues rather than being included in PRs for other UI components.

📚 Learning: 2025-10-21T04:40:36.292Z

Learnt from: linoyaslan
Repo: openshift-assisted/assisted-installer-ui PR: 3190
File: libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx:55-63
Timestamp: 2025-10-21T04:40:36.292Z
Learning: In libs/ui-lib/lib/ocm/components/clusterConfiguration/networkConfiguration/AdvancedNetworkFields.tsx, the network reordering logic in the useEffect (swapping clusterNetworks and serviceNetworks based on the primary machine network's IP family) is for UI consistency only. Validation of empty or invalid CIDRs is handled separately by validation schemas, not by the reordering logic.

Applied to files:

• libs/ui-lib/lib/ocm/hooks/useInfraEnvId.ts

🔇 Additional comments (2)

libs/ui-lib/lib/ocm/hooks/useInfraEnvId.ts (1)

58-63: LGTM! Well-coordinated changes with the service layer.

The conditional error handling appropriately allows clusterId to be optional when the single cluster feature is enabled, and the dependency array correctly includes isSingleClusterFeatureEnabled to ensure the effect re-runs when the feature flag changes.

libs/ui-lib/lib/ocm/services/InfraEnvsService.ts (1)

24-26: The code correctly returns the single infraEnv in single cluster mode without architecture filtering. This is intentional—single cluster mode creates only one infraEnv (as seen in ClustersService.ts line 51), so cpuArchitecture matching is not applicable.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElayAharoni, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rawagner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rawagner]

/jira refresh

[openshift-ci-robot]

@rawagner: This pull request references Jira Issue OCPBUGS-70172, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (vkolodny@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rawagner]

/override ci/prow/okd-scos-images

[openshift-ci]

@rawagner: Overrode contexts on behalf of rawagner: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[rawagner]

/override ci/prow/okd-scos-images

[openshift-ci]

@rawagner: Overrode contexts on behalf of rawagner: ci/prow/okd-scos-images

Details

In response to this:

/override ci/prow/okd-scos-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci-robot]

@ElayAharoni: Jira Issue OCPBUGS-70172: All pull requests linked via external trackers have merged:

• openshift-assisted/assisted-installer-ui#3341

Jira Issue OCPBUGS-70172 has been moved to the MODIFIED state.

Details

In response to this:

https://issues.redhat.com/browse/OCPBUGS-70172

Summary by CodeRabbit

• New Features

• Added single-cluster mode support with automatic infrastructure environment detection and simplified configuration workflow.

• Bug Fixes

• Improved error handling to prevent clusterId validation errors when operating in single-cluster mode.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ElayAharoni]

/cherry-pick release-4.21

[openshift-cherrypick-robot]

@ElayAharoni: new pull request created: #3349

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.