Skip to content

OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message#3376

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
asmasarw:fix/val-name
Feb 4, 2026
Merged

OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message#3376
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
asmasarw:fix/val-name

Conversation

@asmasarw
Copy link
Contributor

@asmasarw asmasarw commented Feb 3, 2026

Before:
image

After:
image

@openshift-ci openshift-ci bot requested review from batzionb and rawagner February 3, 2026 10:28
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 3, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 3, 2026

Warning

Rate limit exceeded

@asmasarw has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 11 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

Two files are updated to introduce a new Rendezvous IP label to the application. A translation key is added to the English locales file, and a corresponding constant is registered in the UI configuration.

Changes

Cohort / File(s) Summary
Rendezvous IP Label Addition
libs/locales/lib/en/translation.json, libs/ui-lib/lib/common/config/constants.ts
Added "ai:RendezvousIP" translation key and registered rendezvousIp in cluster field labels configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A label springs forth with gentle care,
Rendezvous IP now blooms everywhere,
Translation aligned with constants true,
Two rabbit-sized hops, a change shiny and new!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title check ⚠️ Warning The title mentions fixing a 'rendezvousIP field name in error message', but the changes only add new translation keys and UI labels without modifying error messages or field name validation logic. Clarify the title to accurately reflect that the changes add translation and UI label support for rendezvousIP, rather than implying a fix to error message field names.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asmasarw, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 142fdc5 into openshift-assisted:master Feb 4, 2026
12 checks passed
@asmasarw asmasarw deleted the fix/val-name branch February 4, 2026 10:40
ElayAharoni added a commit to ElayAharoni/assisted-installer-ui that referenced this pull request Feb 23, 2026
openshift-merge-bot bot pushed a commit that referenced this pull request Feb 24, 2026
* Revert "UI freezes when clicking Select button without version (#3401)"

This reverts commit 52c39a9.

* Revert "OCPBUGS-75072 | OVE UI: Above-the-sea UI QE test (#3383)"

This reverts commit f61e1b1.

* Revert "OCPBUGS-74421 | OVE UI: Fix rendezvousIP field name in error message (#3376)"

This reverts commit 142fdc5.

* Revert "Add additional new fields to the above the sea UI (#3337)"

This reverts commit 2283bcd.

* Revert "add new fields to above sea level ABI (#3274)"

This reverts commit 41a3210.

* Revert "Assisted Installer OVE UI shows transient blank page with Technology Preview spinner (#3341)"

This reverts commit d47ab5f.
ElayAharoni added a commit to ElayAharoni/assisted-installer-ui that referenced this pull request Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants