Skip to content

Remove operators from ABI that are not yet included#3143

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:remove_abi_operators
Aug 27, 2025
Merged

Remove operators from ABI that are not yet included#3143
openshift-merge-bot[bot] merged 1 commit intoopenshift-assisted:masterfrom
rawagner:remove_abi_operators

Conversation

@rawagner
Copy link
Member

@rawagner rawagner commented Aug 27, 2025

Summary by CodeRabbit

  • Changes
    • Removed Cluster Observability, NUMA Resources, OADP, and MetalLB from the Single-Cluster Operators list in the UI.
    • These operators will no longer appear in operator selection, filtering, or related listings for single-cluster setups.
    • Any UI references to these operators in single-cluster contexts have been removed to reflect the updated availability.

@openshift-ci openshift-ci bot requested review from batzionb and celdrake August 27, 2025 11:28
@coderabbitai
Copy link

coderabbitai bot commented Aug 27, 2025

Walkthrough

The change updates libs/ui-lib/lib/common/config/constants.ts by removing four operator constants from the exported singleClusterOperators array: OPERATOR_NAME_CLUSTER_OBSERVABILITY, OPERATOR_NAME_NUMA_RESOURCES, OPERATOR_NAME_OADP, and OPERATOR_NAME_METALLB.

Changes

Cohort / File(s) Summary
Config constants cleanup
libs/ui-lib/lib/common/config/constants.ts
Removed four entries from singleClusterOperators: OPERATOR_NAME_CLUSTER_OBSERVABILITY, OPERATOR_NAME_NUMA_RESOURCES, OPERATOR_NAME_OADP, OPERATOR_NAME_METALLB.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

lgtm, approved, size/S

Suggested reviewers

  • batzionb
  • ElayAharoni
  • jgyselov

Poem

Four operators hop away today,
Trimmed from the meadow where constants play.
Fewer carrots in the config bin,
Still the cluster hums with a quiet grin.
Thump-thump—clean paths, lighter load,
A happy hare on a tidier road. 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e6b83a4 and 2df8e2f.

📒 Files selected for processing (1)
  • libs/ui-lib/lib/common/config/constants.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • libs/ui-lib/lib/common/config/constants.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: translation-files
  • GitHub Check: circular-deps
  • GitHub Check: tests
  • GitHub Check: lint
  • GitHub Check: format
  • GitHub Check: unit-tests
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2025
@celdrake
Copy link
Contributor

@rawagner Could we mark this as a revert of #3101?
And to update the JIra to reflect that it's being reverted.

@rawagner
Copy link
Member Author

@rawagner Could we mark this as a revert of #3101? And to update the JIra to reflect that it's being reverted.

no, the 3101 contains changes for SaaS as well, but for some reason it added these operators to ABI flow as well

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: celdrake, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2e7ea94 into openshift-assisted:master Aug 27, 2025
11 checks passed
@rawagner
Copy link
Member Author

/cherry-pick releases/v2.44

@openshift-cherrypick-robot
Copy link
Contributor

@rawagner: new pull request created: #3145

Details

In response to this:

/cherry-pick releases/v2.44

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants