MGMT-21373: Add the new virtualization operators to the UI#3101
MGMT-21373: Add the new virtualization operators to the UI#3101openshift-merge-bot[bot] merged 2 commits intoopenshift-assisted:masterfrom
Conversation
|
Caution Review failedFailed to post review comments. Configuration used: CodeRabbit UI 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧠 Learnings (2)📓 Common learnings📚 Learning: 2025-08-11T06:07:38.038ZApplied to files:
🧬 Code Graph Analysis (1)libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (3)
🔇 Additional comments (9)
WalkthroughAdds four OpenShift operator entries (Cluster Observability, NUMA Resources, OADP, MetalLB) across localization, type definitions, operator descriptions/specs, constants, and docs link helpers; all changes are additive. Changes
Sequence Diagram(s)sequenceDiagram
participant UI
participant OperatorSpecs
participant Constants
participant DocsLinks
UI->>OperatorSpecs: Request list of operators
OperatorSpecs->>Constants: Read operator names, validation IDs, descriptions
OperatorSpecs->>DocsLinks: Build doc link (get*Link(openshiftVersion))
OperatorSpecs-->>UI: Return operator specs (title, description, featureId, doc link, support level)
UI-->>User: Render operator entries with descriptions and "Learn more" links
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Welcome @rivkyrizel! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉 |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @rivkyrizel. Thanks for your PR. I'm waiting for a openshift-assisted member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
size/L
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (1)
331-344: Add MetalLB spec — network category fits; flags and links OKEverything is consistent. Minor note: function name
getMetalLbLinkvs acronym casing is acceptable but could be unified project-wide.If desired, rename to
getMetalLBLinkand update imports.libs/ui-lib/lib/common/config/constants.ts (1)
224-227: Failure hints are empty — consider adding actionable guidanceThe new validations have empty failure hints. If possible, add brief guidance or doc links to help users resolve failures, consistent with other validations.
- 'cluster-observability-requirements-satisfied': '', + 'cluster-observability-requirements-satisfied': t('ai:Review Cluster Observability requirements and ensure resources and permissions are configured.'), - 'numa-resources-requirements-satisfied': '', + 'numa-resources-requirements-satisfied': t('ai:Enable NFD and verify NUMA topology/CPU pinning prerequisites.'), - 'oadp-requirements-satisfied': '', + 'oadp-requirements-satisfied': t('ai:Configure backup storage and OADP prerequisites.'), - 'metallb-requirements-satisfied': '', + 'metallb-requirements-satisfied': t('ai:Provide a pool of IP addresses for MetalLB and validate L2/L3 mode prerequisites.'),
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
libs/locales/lib/en/translation.json(4 hunks)libs/types/assisted-installer-service.d.ts(3 hunks)libs/ui-lib/lib/common/components/operators/operatorDescriptions.tsx(1 hunks)libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx(6 hunks)libs/ui-lib/lib/common/config/constants.ts(5 hunks)libs/ui-lib/lib/common/config/docs_links.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (3)
libs/ui-lib/lib/common/config/constants.ts (4)
OPERATOR_NAME_OADP(343-343)OPERATOR_NAME_METALLB(344-344)OPERATOR_NAME_CLUSTER_OBSERVABILITY(341-341)OPERATOR_NAME_NUMA_RESOURCES(342-342)libs/ui-lib/lib/common/components/operators/operatorDescriptions.tsx (4)
DESCRIPTION_OADP(66-67)DESCRIPTION_METALLB(69-70)DESCRIPTION_CLUSTER_OBSERVABILITY(60-61)DESCRIPTION_NUMA_RESOURCES(63-64)libs/ui-lib/lib/common/config/docs_links.ts (4)
getOadpLink(203-206)getMetalLbLink(208-211)getClusterObservabilityLink(213-216)getNumaResourcesLink(218-221)
🔇 Additional comments (11)
libs/ui-lib/lib/common/components/operators/operatorDescriptions.tsx (1)
60-70: Descriptions LGTMClear, concise, and consistent with existing operator descriptions. No changes needed.
libs/types/assisted-installer-service.d.ts (1)
685-690: All new “…-requirements-satisfied” IDs fully wired through the UI and feature logicConfirmed via a repo-wide search that:
libs/ui-lib/lib/common/config/constants.ts
• Validation label mappings include
• 'cluster-observability-requirements-satisfied': t('ai:Cluster Observability requirements')
• 'numa-resources-requirements-satisfied': t('ai:NUMA Resources requirements')
• 'oadp-requirements-satisfied': t('ai:OADP requirements')
• 'metallb-requirements-satisfied': t('ai:MetalLB requirements')
• Blank-string fallbacks and repeat mappings also include the four new keys.libs/ui-lib/lib/common/config/constants.ts
• OPERATOR_NAME_CLUSTER_OBSERVABILITY
• OPERATOR_NAME_NUMA_RESOURCES
• OPERATOR_NAME_OADP
• OPERATOR_NAME_METALLBlibs/ui-lib/lib/common/components/operators/operatorSpecs.tsx
• singleClusterOperators array includes all four new operatorKeys
• operatorSpecs entries reference featureId: 'CLUSTER_OBSERVABILITY', 'NUMA_RESOURCES', 'OADP', 'METALLB'No further changes required.
libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (6)
26-29: Imports updated correctlyNew operator name constants imported as expected. No issues.
36-47: Docs link imports are correctNew link getters are referenced properly.
85-89: Description constants imported correctlyMatches newly added exports. No issues.
193-206: Add OADP spec — correct category and wiring
- Title/featureId/description/link consistent.
- notStandalone and supportLevel usage match existing patterns.
Confirm OADP is enabled only when the virtualization bundle is selected (per PR goal). If gating is handled elsewhere, ensure OPERATOR_NAME_OADP is included in that bundle’s operator list.
463-476: Add Cluster Observability spec — platform category, gating, and support level OKImplementation mirrors existing operators and uses the correct docs link.
Validate virtualization-bundle gating picks this operator up (OPERATOR_NAME_CLUSTER_OBSERVABILITY) so it only appears when expected.
508-521: Add NUMA Resources spec — scheduling category and details look good
- Title/featureId/description/link consistent.
- Marked notStandalone and wired to supportLevel.
As above, confirm virtualization bundle gating includes OPERATOR_NAME_NUMA_RESOURCES.
libs/ui-lib/lib/common/config/constants.ts (3)
257-260: Validation IDs present in service type definitions
Confirmed that all four cluster-level validation IDs are declared inlibs/types/assisted-installer-service.d.ts(lines 686–689 and 1664–1667). TS remains aligned across layers.
153-156: i18n entries verified for new operator requirement labelsConfirmed that the following keys exist in
libs/locales/lib/en/translation.json:
- ai:Cluster Observability requirements (line 173)
- ai:NUMA Resources requirements (line 604)
- ai:OADP requirements (line 625)
- ai:MetalLB requirements (line 524)
No further action needed.
341-344: Verify operator name constants against OLM and UI specsPlease ensure that the exported operator name constants in
constants.tsalign with both the values used inoperatorSpecs.tsxand the identifiers expected by OLM or any validation logic—particularly:
OPERATOR_NAME_NUMA_RESOURCES = 'numaresources'
Confirm whether the OLM bundle, API endpoints, or validation schemas require the hyphenated form ('numa-resources').OPERATOR_NAME_CLUSTER_OBSERVABILITY,OPERATOR_NAME_OADP,OPERATOR_NAME_METALLB
Verify these match their corresponding operator bundle metadata.Key locations to check:
• libs/ui-lib/lib/common/config/constants.ts (lines 341–344)
• libs/ui-lib/lib/common/components/operators/operatorSpecs.tsx (imports at 26–29; NUMA resource spec at 509–511)
rivkyrizel
changed the title
|
@rivkyrizel: This pull request references MGMT-21373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@rivkyrizel: This pull request references MGMT-21373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ammont82, rivkyrizel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit c6b5da0
into
openshift-assisted:master
3 participants
This PR adds 4 new operators to the virtualization bundle:
Cluster Observability, NUMA Resources, OADP, MetalLB.
All these operators are enabled only when the bundle is selected.
Summary by CodeRabbit
New Features
Documentation