Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 15e2411 from #4754.

* Feature addtotals and addcoltotals #4754

Signed-off-by: Asif Bashar <[email protected]>

* Update integ-test/src/test/java/org/opensearch/sql/security/CrossClusterSearchIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>

* Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>

* Update core/src/main/java/org/opensearch/sql/ast/tree/AddColTotals.java

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>

* syntax error fix

Signed-off-by: Asif Bashar <[email protected]>

* syntax error fix

Signed-off-by: Asif Bashar <[email protected]>

* trigger ci workflow

Signed-off-by: Asif Bashar <[email protected]>

* remove line wrapping for relavant md files per recommendation

Signed-off-by: Asif Bashar <[email protected]>

---------

Signed-off-by: Asif Bashar <[email protected]>
Signed-off-by: Asif Bashar <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
(cherry picked from commit 15e2411)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/backport-4754-to-2.19-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@dai-chen
Copy link
Collaborator

CrossClusterSearchIT > testCrossClusterAddTotals() FAILED
    org.opensearch.client.ResponseException: method [POST], host [http://127.0.0.1:46487], URI [/_plugins/_ppl], status line [HTTPr]
    {
      "error": {
        "reason": "There was internal problem at backend",
        "details": "addtotals is supported only when plugins.calcite.enabled=true",
        "type": "UnsupportedOperationException"
      },
      "status": 500
    }
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:479)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:371)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:346)
        at app//org.opensearch.sql.ppl.PPLIntegTestCase.executeQueryToString(PPLIntegTestCase.java:57)
        at app//org.opensearch.sql.ppl.PPLIntegTestCase.executeQuery(PPLIntegTestCase.java:53)
        at app//org.opensearch.sql.security.CrossClusterSearchIT.testCrossClusterAddTotals(CrossClusterSearchIT.java:254)

@dai-chen
Copy link
Collaborator

Publish manual PR to fix the IT: #4964

@dai-chen dai-chen closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant