[Backport 2.19-dev] Feature addtotals and addcoltotals #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Feature addtotals and addcoltotals opensearch-project#4754 Signed-off-by: Asif Bashar <[email protected]> * Update integ-test/src/test/java/org/opensearch/sql/security/CrossClusterSearchIT.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> * Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> * Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> * Update integ-test/src/test/java/org/opensearch/sql/calcite/remote/CalciteAddColTotalsCommandIT.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> * Update core/src/main/java/org/opensearch/sql/ast/tree/AddColTotals.java Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> * syntax error fix Signed-off-by: Asif Bashar <[email protected]> * syntax error fix Signed-off-by: Asif Bashar <[email protected]> * trigger ci workflow Signed-off-by: Asif Bashar <[email protected]> * remove line wrapping for relavant md files per recommendation Signed-off-by: Asif Bashar <[email protected]> --------- Signed-off-by: Asif Bashar <[email protected]> Signed-off-by: Asif Bashar <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Chen Dai <[email protected]>
dai-chen
requested review from
GumpacG,
LantaoJin,
MaxKsyunz,
Swiddis,
YANG-DB,
Yury-Fridlyand,
acarbonetto,
anirudha,
derek-ho,
forestmvey,
joshuali925,
kavithacm,
mengweieric,
noCharger,
penghuo,
ps48,
qianheng-aws,
seankao-az and
ykmr1224
as code owners
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
penghuo
approved these changes
Dec 16, 2025
Swiddis
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 15e2411 from #4754 with integration test fix by enabling Calcite.