Skip to content

Conversation

@opensearch-trigger-bot
Copy link
Contributor

Backport 342a78b from #4605.

…4287 (#4605)

Signed-off-by: Asif Bashar <[email protected]>
(cherry picked from commit 342a78b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch backport/backport-4605-to-2.19-dev

Comment @coderabbitai help to get the list of available commands and usage tips.

@dai-chen
Copy link
Collaborator

New added IT failed. Need to investigate.

2025-12-11T21:45:34.8476709Z org.opensearch.sql.ppl.ConversionFunctionIT > testHex FAILED
2025-12-11T21:45:34.8488318Z     org.opensearch.client.ResponseException: method [POST], 
host [http://127.0.0.1:42695], URI [/_plugins/_ppl], status line [HTTP/1.1 400 Bad Request]
2025-12-11T21:45:34.8489206Z     {
2025-12-11T21:45:34.8489444Z       "error": {
2025-12-11T21:45:34.8489744Z         "reason": "Invalid Query",
2025-12-11T21:45:34.8490169Z         "details": "unsupported function name: tonumber",
2025-12-11T21:45:34.8490664Z         "type": "ExpressionEvaluationException"
2025-12-11T21:45:34.8491054Z       },
2025-12-11T21:45:34.8491301Z       "status": 400
2025-12-11T21:45:34.8491562Z     }

@dai-chen
Copy link
Collaborator

The root cause seems we didn't enable Calcite in ConversionFunctionIT and Calcite is disabled by default: https://github.com/opensearch-project/sql/blame/2.19-dev/opensearch/src/main/java/org/opensearch/sql/opensearch/setting/OpenSearchSettings.java#L173. cc: @asifabashar

@dai-chen
Copy link
Collaborator

Another backport PR failed due to similar reason: #4959

@dai-chen
Copy link
Collaborator

Created issue #4960 for broader topic regarding such boilerplate code. We will need to fix both PRs manually.

@dai-chen
Copy link
Collaborator

Will publish manual PR shortly.

@dai-chen dai-chen closed this Dec 16, 2025
@dai-chen
Copy link
Collaborator

New PR: #4963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant