Updates the style of all java files under the */dlic/util/ dir.#2823
Merged
stephen-crawford merged 4 commits intoopensearch-project:mainfrom Jun 1, 2023
Merged
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
stephen-crawford
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied and
reta
as code owners
11 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) throws KeyManagementException { | ||
| sslContext.init( | ||
| !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null, | ||
| new TrustManager[] { new OverlyTrustfulTrustManager() }, |
Check failure
Code scanning / CodeQL
`TrustManager` that accepts all certificates
| ) throws KeyManagementException { | ||
| sslContext.init( | ||
| !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null, | ||
| new TrustManager[] { new OverlyTrustfulTrustManager() }, |
Check failure
Code scanning / CodeQL
`TrustManager` that accepts all certificates
3 tasks
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #2823 +/- ##
============================================
- Coverage 61.61% 61.59% -0.02%
Complexity 3413 3413
============================================
Files 266 266
Lines 18893 18917 +24
Branches 3305 3303 -2
============================================
+ Hits 11640 11652 +12
- Misses 5656 5669 +13
+ Partials 1597 1596 -1
|
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
3 tasks
reta
approved these changes
May 31, 2023
RyanL1997
reviewed
May 31, 2023
| apply plugin: 'opensearch.pluginzip' | ||
| apply plugin: 'opensearch.rest-test' | ||
| apply plugin: 'opensearch.testclusters' | ||
| //apply from: 'gradle/formatting.gradle' |
Collaborator
There was a problem hiding this comment.
nit: should we just remove it? Or just leave as comment
Contributor
Author
There was a problem hiding this comment.
I think we are going to leave it as a comment for the time being per this conversation: #2821 (comment)
RyanL1997
approved these changes
May 31, 2023
This was referenced Jun 1, 2023
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…search-project#2823) * rebase Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update java style under **/auth Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Util dir Signed-off-by: Stephen Crawford <steecraw@amazon.com> * readd formatting Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
MaciejMierzwa
pushed a commit
to MaciejMierzwa/security
that referenced
this pull request
Jun 13, 2023
…search-project#2823) * rebase Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update java style under **/auth Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Util dir Signed-off-by: Stephen Crawford <steecraw@amazon.com> * readd formatting Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>
This was referenced Jun 13, 2023
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…search-project#2823) * rebase Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update java style under **/auth Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Util dir Signed-off-by: Stephen Crawford <steecraw@amazon.com> * readd formatting Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…search-project#2823) * rebase Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update java style under **/auth Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Util dir Signed-off-by: Stephen Crawford <steecraw@amazon.com> * readd formatting Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>
samuelcostae
pushed a commit
to samuelcostae/security
that referenced
this pull request
Jun 19, 2023
…search-project#2823) * rebase Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update java style under **/auth Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Util dir Signed-off-by: Stephen Crawford <steecraw@amazon.com> * readd formatting Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>
peternied
added a commit
to peternied/security
that referenced
this pull request
Aug 3, 2023
…til/ dir Backporting opensearch-project#2823 Signed-off-by: Peter Nied <petern@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows #2822. Updates all java files unders
**/util/.Check List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.