Update *.java style for security/action/*#2824
Closed
stephen-crawford wants to merge 4 commits intoopensearch-project:mainfrom
Closed
Update *.java style for security/action/*#2824stephen-crawford wants to merge 4 commits intoopensearch-project:mainfrom
stephen-crawford wants to merge 4 commits intoopensearch-project:mainfrom
Conversation
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
Signed-off-by: Stephen Crawford <steecraw@amazon.com>
stephen-crawford
requested review from
DarshitChanpura,
RyanL1997,
cliu123,
cwperks,
davidlago,
peternied and
reta
as code owners
This was referenced May 31, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ) throws KeyManagementException { | ||
| sslContext.init( | ||
| !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null, | ||
| new TrustManager[] { new OverlyTrustfulTrustManager() }, |
Check failure
Code scanning / CodeQL
`TrustManager` that accepts all certificates
| ) throws KeyManagementException { | ||
| sslContext.init( | ||
| !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null, | ||
| new TrustManager[] { new OverlyTrustfulTrustManager() }, |
Check failure
Code scanning / CodeQL
`TrustManager` that accepts all certificates
DarshitChanpura
approved these changes
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## main #2824 +/- ##
=========================================
Coverage 61.61% 61.61%
- Complexity 3413 3414 +1
=========================================
Files 266 266
Lines 18893 18917 +24
Branches 3305 3303 -2
=========================================
+ Hits 11640 11655 +15
- Misses 5656 5667 +11
+ Partials 1597 1595 -2
|
Contributor
Author
|
Closing this because so few changes are present here. Going to condense with other packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follows #2823.
Updates the style for java files under the
**/security/action/dir.Check List
New functionality includes testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.