Updates all java files under security/* and test/security/a* -> test/security/m* by stephen-crawford · Pull Request #2826 · opensearch-project/security

stephen-crawford · 2023-05-31T16:21:02Z

Follows #2823
Updates all java files under security/auth to security/filter.

Check List

~~New functionality includes testing~~
New functionality has been documented
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

src/main/java/com/amazon/dlic/util/SettingsBasedSSLConfigurator.java

+        ) throws KeyManagementException {
+            sslContext.init(
+                !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null,
+                new TrustManager[] { new OverlyTrustfulTrustManager() },


src/main/java/com/amazon/dlic/util/SettingsBasedSSLConfiguratorV4.java

+        ) throws KeyManagementException {
+            sslContext.init(
+                !keyManagers.isEmpty() ? keyManagers.toArray(new KeyManager[keyManagers.size()]) : null,
+                new TrustManager[] { new OverlyTrustfulTrustManager() },


codecov · 2023-05-31T16:51:16Z

Codecov Report

Merging #2826 (f41fb94) into main (76a5d7f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #2826      +/-   ##
============================================
- Coverage     61.60%   61.59%   -0.01%     
+ Complexity     3414     3413       -1     
============================================
  Files           266      266              
  Lines         18917    18917              
  Branches       3303     3303              
============================================
- Hits          11653    11652       -1     
  Misses         5669     5669              
- Partials       1595     1596       +1

see 1 file with indirect coverage changes

reta · 2023-05-31T19:08:53Z

build.gradle

+    java {
+        // Normally this isn't necessary, but we have Java sources in
+        // non-standard places
+        target '**/com/amazon/dlic/**/*.java'


Hm .. same as #2823

Hi @reta, sorry I am not sure I know what you are referencing here :/. I assume you are looking at the list of targets which I know is not the prettiest way of doing things. Unfortunately, I did not see a ton of options for creating a clearer description of which directories have the new formatting in place.

Do you have a suggestion you would like me to follow?

My sincere apologies, pasted wrong link here (not sure how), I meant this #2823 - seems like doing the same changes ....

Oh gotcha. Yeah, for whatever reason, there does not seem to be many changes within the target set here. I will rebase and expand the range to include more. It is hard to tell before rebasing what is actually new. Good catch.

Now should have changes under security/* and test/security/a* up to test/security/m*

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

stephen-crawford · 2023-06-02T20:49:52Z

@DarshitChanpura @RyanL1997 either of you have a chance to review this? :) Thank you

…security/m* (opensearch-project#2826) * Update Sec/action to Sec/Filter Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* and test/opensearch/security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Maciej Mierzwa <dev.maciej.mierzwa@gmail.com>

…security/m* (opensearch-project#2826) * Update Sec/action to Sec/Filter Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* and test/opensearch/security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com>

…security/m* (opensearch-project#2826) * Update Sec/action to Sec/Filter Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Update Security/* and test/opensearch/security/* Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> * Half sec test changes Signed-off-by: Stephen Crawford <steecraw@amazon.com> --------- Signed-off-by: Stephen Crawford <steecraw@amazon.com> Signed-off-by: Sam <samuel.costa@eliatra.com>

stephen-crawford requested review from DarshitChanpura, RyanL1997, cliu123, cwperks, davidlago, peternied and reta as code owners May 31, 2023 16:21

stephen-crawford mentioned this pull request May 31, 2023

Standardize code style & formatting throughout repository #2809

Closed

11 tasks

github-advanced-security bot found potential problems May 31, 2023

View reviewed changes

stephen-crawford changed the title ~~Updates all java files under security/auth to security/filter~~ Updates all java files under security/action to security/filter May 31, 2023

reta reviewed May 31, 2023

View reviewed changes

stephen-crawford closed this Jun 1, 2023

stephen-crawford force-pushed the updateSecAuthToFilter branch from 511410f to 76a5d7f Compare June 1, 2023 14:21

stephen-crawford added 3 commits June 1, 2023 10:22

Update Sec/action to Sec/Filter

12c381f

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

Update Security/*

57516f4

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

Update Security/* and test/opensearch/security/*

1193c42

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

stephen-crawford reopened this Jun 1, 2023

stephen-crawford changed the title ~~Updates all java files under security/action to security/filter~~ Updates all java files under security/* and test/security/* Jun 1, 2023

Half sec test changes

825d365

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

stephen-crawford force-pushed the updateSecAuthToFilter branch from 19d1db0 to 825d365 Compare June 1, 2023 14:38

Half sec test changes

f41fb94

Signed-off-by: Stephen Crawford <steecraw@amazon.com>

stephen-crawford changed the title Updates all java files under security/* and test/security/* Updates all java files under security/* and test/security/a* -> test/security/m* Jun 1, 2023

reta approved these changes Jun 1, 2023

View reviewed changes

cwperks approved these changes Jun 5, 2023

View reviewed changes

stephen-crawford merged commit cb8818c into opensearch-project:main Jun 5, 2023

RyanL1997 mentioned this pull request Jun 13, 2023

Sync up security/extensions feature branch with main on 06/13/2023 #2853

Closed

3 tasks

RyanL1997 mentioned this pull request Jun 13, 2023

Sync up security/extensions feature branch with main on 06/13/2023 #2854

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates all java files under security/* and test/security/a* -> test/security/m*#2826

Updates all java files under security/* and test/security/a* -> test/security/m*#2826
stephen-crawford merged 5 commits intoopensearch-project:mainfrom
stephen-crawford:updateSecAuthToFilter

stephen-crawford commented May 31, 2023 •

edited

Loading

Uh oh!

Check failure

Check failure

codecov bot commented May 31, 2023 •

edited

Loading

Uh oh!

reta May 31, 2023 •

edited

Loading

Uh oh!

stephen-crawford Jun 1, 2023

Uh oh!

reta Jun 1, 2023

Uh oh!

stephen-crawford Jun 1, 2023

Uh oh!

stephen-crawford Jun 1, 2023 •

edited

Loading

Uh oh!

stephen-crawford commented Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

stephen-crawford commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Check List

Uh oh!

Check failure

Check failure

codecov bot commented May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

reta May 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephen-crawford Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

reta Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

stephen-crawford Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

stephen-crawford Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stephen-crawford commented Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

stephen-crawford commented May 31, 2023 •

edited

Loading

codecov bot commented May 31, 2023 •

edited

Loading

reta May 31, 2023 •

edited

Loading

stephen-crawford Jun 1, 2023 •

edited

Loading