Adds workflow that fails CI check on purpose if a pull request target was deprecated branch#2145
Closed
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
Closed
Conversation
DarshitChanpura
force-pushed
the
protect-deprecated-branches
branch
from
b9ade93 to
0baeced
Compare
DarshitChanpura
added
backport 1.x
peternied
previously approved these changes
Oct 5, 2022
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Nicely done! This is a really clean way to protect our branches
| branches: | ||
| - '1.0' | ||
| - '1.1' | ||
| - '1.2' |
Member
There was a problem hiding this comment.
What about 2.3? Is this going to be a new step on every release to append to this list?
Member
There was a problem hiding this comment.
2.3 can still get patch releases, only after 2.4 ships would we add this block
Member
|
This looks like a viable solution to #2025 |
…ated branch Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
dismissed stale reviews from peternied and stephen-crawford
via
d3fe71d
DarshitChanpura
force-pushed
the
protect-deprecated-branches
branch
from
0baeced to
d3fe71d
Compare
peternied
suggested changes
Oct 6, 2022
Member
peternied
left a comment
peternied
left a comment
There was a problem hiding this comment.
Until we have alignment on open issues on opensearch-project/security-dashboards-plugin#1127 and this PR lets not merge
|
Closing after clarifying the back-porting policy here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a workflow that is built to fail on trigger. This workflow will only be triggered when a pull-request is opened against a deprecated branch mentioned in the workflow yaml, to prevent changes from going in.
Testing
Manual testing
See opensearch-project/security-dashboards-plugin#1127 for details
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.