Adds workflow that fails CI check on purpose if a pull request target was deprecated branch#1127
Closed
DarshitChanpura wants to merge 1 commit intoopensearch-project:mainfrom
Closed
Conversation
DarshitChanpura
added
backport 1.3
backport 2.0
Codecov Report
@@ Coverage Diff @@
## main #1127 +/- ##
=======================================
Coverage 74.43% 74.43%
=======================================
Files 86 86
Lines 1874 1874
Branches 244 244
=======================================
Hits 1395 1395
Misses 424 424
Partials 55 55 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 tasks
DarshitChanpura
force-pushed
the
protect-deprecated-branches
branch
from
bbe609f to
69fea2d
Compare
…ated branch Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
DarshitChanpura
force-pushed
the
protect-deprecated-branches
branch
from
69fea2d to
403dd75
Compare
cliu123
requested changes
Oct 6, 2022
Member
cliu123
left a comment
cliu123
left a comment
There was a problem hiding this comment.
I don’t think we should fail CI on those branches on purpose. The branches are not abandoned. CI should be healthy.
Member
Singling out the 1.0 branch, we have not backporting any security or bug fixes and there are no plans to release updates as the OpenSearch distribution. If this isn't abandoned, what level of support are we maintaining for these branches? |
|
Closing after clarifying the back-porting policy here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds a workflow that is built to fail on trigger. This workflow will only be triggered when a pull-request is opened against a deprecated branch mentioned in the workflow yaml, to prevent changes from going in.
Category
Maintenance
Why these changes are required?
This change will serve as a reminder for Maintainers to not merge PRs into deprecated branches accidentally.
Testing
Manual testing
mainwas part ofdeprecated-branches.ymlmainwasn't part ofdeprecated-branches.ymlCheck List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.