Skip to content

Adds workflow that fails CI check on purpose if a pull request target was deprecated branch #2145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DarshitChanpura wants to merge 1 commit into from
Closed

Adds workflow that fails CI check on purpose if a pull request target was deprecated branch #2145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/deprecated-branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Merge protection against deprecated branches

on:
pull_request:
# Every-time a branch is deprecated it should be added here
branches:
- '1.0'
- '1.1'
- '1.2'
Copy link
Member

@peternied peternied Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add 2.0, 2.1, 2.2?

Copy link
Member

@peternied peternied Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also 1.x

Copy link
Member

@cwperks cwperks Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about 2.3? Is this going to be a new step on every release to append to this list?

Copy link
Member

@peternied peternied Oct 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3 can still get patch releases, only after 2.4 ships would we add this block

- '1.x'
- '2.0'
- '2.1'
- '2.2'

jobs:
deprecated-branch-check:
runs-on: ubuntu-latest
name: Deprecated Branch Check
steps:
- name: Fail if this workflow is triggered
run: echo -e "\n\nThis PR was created against the branch ${GH_BRANCH##*/} that was deprecated\n\n";
exit 1
env:
GH_BRANCH: ${{ github.ref }}