[Backport 2.x] Support CI for Windows and MacOS (#1164)#1167
Merged
Conversation
3 tasks
peternied
force-pushed
the
backport/backport-1164-to-2.x
branch
from
0395d12 to
acf2ccb
Compare
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be)
Signed-off-by: Peter Nied <petern@amazon.com>
peternied
force-pushed
the
backport/backport-1164-to-2.x
branch
from
acf2ccb to
b0e2d4e
Compare
Member
Author
|
@RyanL1997 Could you take a look at this to help get it merged for 2.4? |
Member
Author
|
@opensearch-project/security Can I get another review on this please? |
cwperks
approved these changes
Nov 1, 2022
cwperks
reviewed
Nov 1, 2022
| - id: branch-switch-if-possible | ||
| continue-on-error: true # Defaults onto main if the branch switch doesn't work | ||
| if: ${{ steps.osd-version.outputs.osd-version }} | ||
| run: git checkout ${{ steps.osd-version.outputs.osd-version }} || git checkout ${{ steps.osd-version.outputs.osd-x-version }}x |
Member
Author
There was a problem hiding this comment.
all branch and tag names are case sensitive by design
From https://stackoverflow.com/a/57754769/533057
Sounds like it.
3 tasks
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
* Support CI for Windows and MacOS (#1164) Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be) * Support checkout out #.X branch types Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a8278c1)
peternied
added a commit
that referenced
this pull request
Nov 2, 2022
* Support CI for Windows and MacOS (#1164) Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be) * Support checkout out #.X branch types Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a8278c1) Co-authored-by: Peter Nied <petern@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe.
Signed-off-by: Peter Nied petern@amazon.com
(cherry picked from commit a21c7be)
Check List
New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.