Support CI for Windows and MacOS#1164
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Oct 28, 2022
Merged
Conversation
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com>
peternied
added
backport 2.x
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 73.90% 72.07% -1.84%
==========================================
Files 86 88 +2
Lines 1901 1959 +58
Branches 251 258 +7
==========================================
+ Hits 1405 1412 +7
- Misses 439 490 +51
Partials 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
davidlago
approved these changes
Oct 28, 2022
davidlago
left a comment
davidlago
left a comment
There was a problem hiding this comment.
Nice refactoring, thanks for taking care of this
Member
|
@peternied Looks like we have to modify the required checks similar to what @cliu123 did for this PR: opensearch-project/security#2161 (comment) |
cwperks
approved these changes
Oct 28, 2022
| steps: | ||
| - id: determine-dashboards-directory | ||
| run: echo "dashboards-directory=OpenSearch-Dashboards" >> $GITHUB_OUTPUT | ||
| shell: bash |
Member
There was a problem hiding this comment.
Looks like bash is available on all platforms according to this: https://dev.to/pwd9000/github-actions-all-the-shells-581h
Nice use of a composite action! 🙌
| - uses: actions/checkout@v2 | ||
|
|
||
| - id: install-dashboards | ||
| uses: ./.github/actions/install-dashboards |
Contributor
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1164-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a21c7be155c082ede6bb24b9a691805ff1431f03
# Push it to GitHub
git push --set-upstream origin backport/backport-1164-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
Member
Author
|
FYI The backport to 2.x #1167 |
peternied
added a commit
that referenced
this pull request
Oct 31, 2022
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be)
peternied
added a commit
that referenced
this pull request
Nov 1, 2022
* Support CI for Windows and MacOS (#1164) Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be) * Support checkout out #.X branch types Signed-off-by: Peter Nied <petern@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 1, 2022
* Support CI for Windows and MacOS (#1164) Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be) * Support checkout out #.X branch types Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a8278c1)
peternied
added a commit
that referenced
this pull request
Nov 2, 2022
* Support CI for Windows and MacOS (#1164) Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe. Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a21c7be) * Support checkout out #.X branch types Signed-off-by: Peter Nied <petern@amazon.com> (cherry picked from commit a8278c1) Co-authored-by: Peter Nied <petern@amazon.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Creates a github action to install and configure Dashboards that is reused within the workflows of this repository, its multi-platform safe.
Issues Resolved
Note: follow up pull request will convert the integration test job to be multi-platform
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.