Support checkout out #.x branch types#1179
Merged
peternied merged 1 commit intoopensearch-project:mainfrom Nov 2, 2022
Merged
Conversation
Signed-off-by: Peter Nied <petern@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 71.82% 71.82%
=======================================
Files 88 88
Lines 2023 2023
Branches 268 268
=======================================
Hits 1453 1453
Misses 508 508
Partials 62 62 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DarshitChanpura
approved these changes
Nov 2, 2022
Member
DarshitChanpura
left a comment
DarshitChanpura
left a comment
There was a problem hiding this comment.
LGTM! Added one quick comment.
| continue-on-error: true # Defaults onto main if the branch switch doesn't work | ||
| if: ${{ steps.osd-version.outputs.osd-version }} | ||
| run: git checkout ${{ steps.osd-version.outputs.osd-version }} -b v${{ steps.osd-version.outputs.osd-version }} | ||
| run: git checkout ${{ steps.osd-version.outputs.osd-version }} || git checkout ${{ steps.osd-version.outputs.osd-x-version }}x |
Member
There was a problem hiding this comment.
I like the idea of not creating new branch vX.y every-time this step runs. Qq, this change is expected corrected?
Member
Author
There was a problem hiding this comment.
Yup, I did this on purpose, didn't seem to be much purpose to creating a new branch when we just want to checkout and build.
cwperks
approved these changes
Nov 2, 2022
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support checkout out #.x branch types
This change was included in change #1167 that was merged into 2.x
Check List
New functionality includes testingNew functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.