Move WLM description to per-rule field (#525) - #528
Merged
KishoreKicha14 merged 2 commits intoMay 27, 2026
Merged
Conversation
Signed-off-by: David Zane <davizane@amazon.com>
dzane17
force-pushed
the
fix-wlm-description-525
branch
from
May 27, 2026 16:06
b34cdf7 to
598289d
Compare
dzane17
marked this pull request as ready for review
May 27, 2026 16:39
dzane17
requested review from
KishoreKicha14,
ansjcy,
deshsidd and
jainankitk
as code owners
May 27, 2026 16:39
Member
|
@ansjcy , @KishoreKicha14 can u take a look at this? |
Signed-off-by: David Zane <davizane@amazon.com>
Member
Author
|
@kkhatua Originally I thought 1 line should be sufficient because input is all CSV. However for long strings, auto expand will be more friendly than horizontal scroll. I have made this change.
|
KishoreKicha14
merged commit May 27, 2026
8f97137
into
opensearch-project:main
11 of 12 checks passed
Member
Author
|
Mend check will be fixed in #527 after OSD bumps their version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug fix
The previous WLM group
Descriptionfield was semantically incorrect and nonfunctional. Workload group objects have nodescriptionattribute, so values typed into that field were never saved on the group. The dashboard worked around this by writing the string into the WLM rule description field. This PR makesDescriptionproperly display and save as a per-rule attribute instead of per-group.Other cosmetic changes
Screenshots
Old Create Group Page

New Create Group Page

Old Group Details Page

New Group Details Page

Issues Resolved
Resolves #525
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.