Skip to content

Move WLM description to per-rule field (#525) - #528

Merged
KishoreKicha14 merged 2 commits into
opensearch-project:mainfrom
dzane17:fix-wlm-description-525
May 27, 2026
Merged

KishoreKicha14 merged 2 commits into
opensearch-project:mainfrom
dzane17:fix-wlm-description-525

Conversation

@dzane17

@dzane17 dzane17 commented May 27, 2026 •

Copy link
Copy Markdown
Member

Bug fix

The previous WLM group Description field was semantically incorrect and nonfunctional. Workload group objects have no description attribute, so values typed into that field were never saved on the group. The dashboard worked around this by writing the string into the WLM rule description field. This PR makes Description properly display and save as a per-rule attribute instead of per-group.

Other cosmetic changes

  • Per-rule fields (Description, Username, Role, Index wildcard) collapsed from 4 stacked rows to a 2x2 grid (Description top-left, Index wildcard top-right, Username bottom-left, Role bottom-right). Auto-stacks to 4x1 on narrow viewports.
  • Replaced multi-line text input with single-line input all four rule fields. This reduces the vertical page size drastically.

Screenshots

Old Create Group Page
Screenshot 2026-05-27 at 8 35 38 AM

New Create Group Page
Screenshot 2026-05-27 at 8 36 24 AM

Old Group Details Page
Screenshot 2026-05-26 at 8 24 34 PM

New Group Details Page
Screenshot 2026-05-26 at 8 14 29 PM

Issues Resolved

Resolves #525

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: David Zane <davizane@amazon.com>
@dzane17
dzane17 force-pushed the fix-wlm-description-525 branch from b34cdf7 to 598289d Compare May 27, 2026 16:06
@dzane17
dzane17 marked this pull request as ready for review May 27, 2026 16:39
@kkhatua

kkhatua commented May 27, 2026 •

Copy link
Copy Markdown
Member

@ansjcy , @KishoreKicha14 can u take a look at this?
@dzane17 can we make the text box multiline with initial size of single line, but resizeable?

Signed-off-by: David Zane <davizane@amazon.com>
@dzane17

dzane17 commented May 27, 2026

Copy link
Copy Markdown
Member Author

@kkhatua Originally I thought 1 line should be sufficient because input is all CSV. However for long strings, auto expand will be more friendly than horizontal scroll. I have made this change.

Screenshot 2026-05-27 at 11 15 13 AM

@KishoreKicha14 KishoreKicha14 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KishoreKicha14
KishoreKicha14 merged commit 8f97137 into opensearch-project:main May 27, 2026
11 of 12 checks passed
@dzane17

dzane17 commented May 27, 2026

Copy link
Copy Markdown
Member Author

Mend check will be fixed in #527 after OSD bumps their version

@dzane17
dzane17 deleted the fix-wlm-description-525 branch May 27, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] WLM group "Description" does not save

3 participants