Skip to content

Move WLM description to per-rule field (#525) #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KishoreKicha14 merged 2 commits into from
May 27, 2026
Merged

Move WLM description to per-rule field (#525) #528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
598289d
Move WLM description to per-rule field (#525)
dzane17 May 27, 2026
583d3b5
Make text boxes auto expand
dzane17 May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions cypress/e2e/wlm-no-security/7_WLM_details.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ describe('WLM Details Page', () => {
cy.get('[data-testid="wlm-tab-settings"]').click();
cy.contains('+ Add another rule').click();

cy.get('textarea[data-testid="indexInput"]').last().type(i1);
cy.get('[data-testid="indexInput"]').last().type(i1);

cy.contains('button', /^Apply Changes$/)
.should('not.be.disabled')
Expand All @@ -92,13 +92,12 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.contains(i1, { timeout: 20000 }).should('exist');
cy.get('[data-testid="indexInput"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(i1);
});

cy.get('textarea[data-testid="indexInput"]')
.last()
.type('{selectAll}{backspace}')
.type(i2)
.blur();
cy.get('[data-testid="indexInput"]').last().type('{selectAll}{backspace}').type(i2).blur();

cy.contains('button', /^Apply Changes$/)
.should('not.be.disabled')
Expand All @@ -109,8 +108,11 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.contains(i2, { timeout: 20000 }).should('exist');
cy.contains(i1).should('not.exist');
cy.get('[data-testid="indexInput"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(i2);
expect(values).to.not.include(i1);
});

cy.get('button[aria-label="Delete rule"]', { timeout: 20000 }).last().click({ force: true });

Expand All @@ -123,7 +125,7 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.get('textarea[data-testid="indexInput"]').should(($areas) => {
cy.get('[data-testid="indexInput"]').should(($areas) => {
const values = Array.from($areas, (el) => (el.value || '').trim());
expect(values).to.not.include(i2);
});
Expand Down
68 changes: 37 additions & 31 deletions cypress/e2e/wlm/7_WLM_details.cy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@ describe('WLM Details Page', () => {
cy.get('[data-testid="wlm-tab-settings"]').click();
cy.contains('+ Add another rule').click();

cy.get('textarea[placeholder="Enter username"]').last().type(u1);
cy.get('textarea[placeholder="Enter role"]').last().type(r1);
cy.get('textarea[data-testid="indexInput"]').last().type(i1);
cy.get('[placeholder="Enter username"]').last().type(u1);
cy.get('[placeholder="Enter role"]').last().type(r1);
cy.get('[data-testid="indexInput"]').last().type(i1);

cy.contains('button', /^Apply Changes$/)
.should('not.be.disabled')
Expand All @@ -90,25 +90,22 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.contains(u1, { timeout: 20000 }).should('exist');
cy.contains(r1, { timeout: 20000 }).should('exist');
cy.contains(i1, { timeout: 20000 }).should('exist');

cy.get('textarea[placeholder="Enter username"]')
.last()
.type('{selectAll}{backspace}')
.type(u2)
.blur();
cy.get('textarea[placeholder="Enter role"]')
.last()
.type('{selectAll}{backspace}')
.type(r2)
.blur();
cy.get('textarea[data-testid="indexInput"]')
.last()
.type('{selectAll}{backspace}')
.type(i2)
.blur();
cy.get('[placeholder="Enter username"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(u1);
});
cy.get('[placeholder="Enter role"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(r1);
});
cy.get('[data-testid="indexInput"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(i1);
});

cy.get('[placeholder="Enter username"]').last().type('{selectAll}{backspace}').type(u2).blur();
cy.get('[placeholder="Enter role"]').last().type('{selectAll}{backspace}').type(r2).blur();
cy.get('[data-testid="indexInput"]').last().type('{selectAll}{backspace}').type(i2).blur();

cy.contains('button', /^Apply Changes$/)
.should('not.be.disabled')
Expand All @@ -119,12 +116,21 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.contains(u2, { timeout: 20000 }).should('exist');
cy.contains(r2, { timeout: 20000 }).should('exist');
cy.contains(i2, { timeout: 20000 }).should('exist');
cy.contains(u1).should('not.exist');
cy.contains(r1).should('not.exist');
cy.contains(i1).should('not.exist');
cy.get('[placeholder="Enter username"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(u2);
expect(values).to.not.include(u1);
});
cy.get('[placeholder="Enter role"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(r2);
expect(values).to.not.include(r1);
});
cy.get('[data-testid="indexInput"]', { timeout: 20000 }).should(($els) => {
const values = Array.from($els, (el) => (el.value || '').trim());
expect(values).to.include(i2);
expect(values).to.not.include(i1);
});

cy.get('button[aria-label="Delete rule"]', { timeout: 20000 }).last().click({ force: true });

Expand All @@ -137,15 +143,15 @@ describe('WLM Details Page', () => {
cy.wait('@listRules');
cy.get('[data-testid="wlm-tab-settings"]').click();

cy.get('textarea[placeholder="Enter username"]').should(($areas) => {
cy.get('[placeholder="Enter username"]').should(($areas) => {
const values = Array.from($areas, (el) => (el.value || '').trim());
expect(values).to.not.include(u2);
});
cy.get('textarea[placeholder="Enter role"]').should(($areas) => {
cy.get('[placeholder="Enter role"]').should(($areas) => {
const values = Array.from($areas, (el) => (el.value || '').trim());
expect(values).to.not.include(r2);
});
cy.get('textarea[data-testid="indexInput"]').should(($areas) => {
cy.get('[data-testid="indexInput"]').should(($areas) => {
const values = Array.from($areas, (el) => (el.value || '').trim());
expect(values).to.not.include(i2);
});
Expand Down
Loading
Loading