Explorer's timeheader & color change by paulstn · Pull Request #959 · opensearch-project/dashboards-observability

paulstn · 2023-08-25T19:07:07Z

Description

In log explorer, moves the granularity selector down and includes a date&time range next to it, in order to bring the UI closer in line with the rest of Opensearch. The color of the chart also now follows Opensearch UI guidelines.

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

public/components/event_analytics/explorer/timechart_header/timechart_header.tsx

common/constants/explorer.ts

common/constants/shared.ts

public/components/event_analytics/explorer/explorer.tsx

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

…ds-observability into explorer-header-color

mengweieric · 2023-09-07T17:43:56Z

Please address test failures

…ds-observability into explorer-header-color

…shboards-observability; branch 'main' of https://github.com/opensearch-project/dashboards-observability into explorer-header-color

* horizontal to vertical hits/timechart * Added timespan to the header * Color and y-axis name change --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

paulstn marked this pull request as ready for review August 25, 2023 19:07

paulstn requested review from Swiddis, YANG-DB, anirudha, dai-chen, derek-ho, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar as code owners August 25, 2023 19:07

paulstn added 10 commits August 25, 2023 15:03

horizontal to vertical hits/timechart

141e9a8

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Added timespan to the header

1486cca

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Correct formatting of timespan header

1c9eece

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

small todo reminder

5fe2524

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Fixing type issues and undefined behavior

55a9c3b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Color and y-axis name change

aab5046

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

fix timechart header to be up to date

655cdc6

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added all snapshots

d3755a8

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added upstream snapshots

227eefa

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

added one missing snapshot

700d764

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn force-pushed the explorer-header-color branch from 813d1ab to 700d764 Compare August 25, 2023 22:03

paulstn added 4 commits August 28, 2023 10:29

snapshot

12b4fef

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

jest test change upload

9d2dd25

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

constant datetimes to timeheader added

19391eb

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Updated OSD to get new snapshots

6aa863b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn added 2 commits August 28, 2023 16:15

remove redundant field, update constants, move daterange up

1b1a74b

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

snapshot

1244818

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

ps48 reviewed Aug 29, 2023

View reviewed changes

public/components/event_analytics/explorer/timechart_header/timechart_header.tsx Outdated Show resolved Hide resolved

ps48 reviewed Aug 29, 2023

View reviewed changes

public/components/event_analytics/explorer/timechart_header/timechart_header.tsx Outdated Show resolved Hide resolved

mengweieric reviewed Aug 29, 2023

View reviewed changes

common/constants/explorer.ts Show resolved Hide resolved

common/constants/shared.ts Show resolved Hide resolved

pjfitzgibbons reviewed Aug 29, 2023

View reviewed changes

common/constants/shared.ts Show resolved Hide resolved

public/components/event_analytics/explorer/explorer.tsx Show resolved Hide resolved

paulstn added 3 commits August 29, 2023 09:36

remove unneeded brackets

db240fb

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

change back color

da63e09

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

code clarity change

1d23803

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

paulstn requested review from mengweieric, pjfitzgibbons and ps48 August 29, 2023 16:53

paulstn force-pushed the explorer-header-color branch 2 times, most recently from 715e98a to 1d23803 Compare August 29, 2023 17:16

paulstn added 5 commits August 29, 2023 10:25

updated snapshots

f8b3188

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

change back some code

00eafa3

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

modify line to use lodash array sum

c3c790f

Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Merge branch 'main' of https://github.com/opensearch-project/dashboar…

ae81d0d

…ds-observability into explorer-header-color

Merge branch 'main' of https://github.com/opensearch-project/dashboar…

92fa380

…ds-observability into explorer-header-color

Merge branch 'main' of https://github.com/opensearch-project/dashboar…

a91c993

…ds-observability into explorer-header-color

ps48 approved these changes Sep 7, 2023

View reviewed changes

Merge branch 'explorer-header-color' of https://github.com/paulstn/da…

f1e5bfe

…shboards-observability; branch 'main' of https://github.com/opensearch-project/dashboards-observability into explorer-header-color

pjfitzgibbons approved these changes Sep 8, 2023

View reviewed changes

pjfitzgibbons merged commit 9d353a6 into opensearch-project:main Sep 8, 2023

pjfitzgibbons pushed a commit that referenced this pull request Sep 26, 2023

Explorer's timeheader & color change (#959)

92bf42e

* horizontal to vertical hits/timechart * Added timespan to the header * Color and y-axis name change --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Explorer's timeheader & color change#959

Explorer's timeheader & color change#959
pjfitzgibbons merged 26 commits intoopensearch-project:mainfrom
paulstn:explorer-header-color

paulstn commented Aug 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mengweieric commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

paulstn commented Aug 25, 2023

Description

Issues Resolved

Check List

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mengweieric commented Sep 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants