Create Data sources plugin with Manage Datasources Flow #1035
Merged
Conversation
* fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
* add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
* rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
…#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
* basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
derek-ho
requested review from
Swiddis,
YANG-DB,
anirudha,
dai-chen,
joshuali925,
kavithacm,
mengweieric,
penghuo,
pjfitzgibbons,
ps48,
rupal-bq,
seankao-az and
vamsimanohar
as code owners
* Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #1035 +/- ##
==========================================
+ Coverage 43.71% 45.47% +1.76%
==========================================
Files 313 329 +16
Lines 18714 19968 +1254
Branches 4562 4863 +301
==========================================
+ Hits 8180 9080 +900
+ Misses 10492 10312 -180
- Partials 42 576 +534
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
approved these changes
Sep 22, 2023
Member
ps48
left a comment
ps48
left a comment
There was a problem hiding this comment.
Looks good. Minor: It would be better if we have couple of folders inside data_connections/components -> configuration_details and connection_details.
Collaborator
Author
Yes good idea - I am addressing in this follow up PR: #1046, it was getting quite confusing so folders should help |
mengweieric
approved these changes
Sep 25, 2023
derek-ho
changed the title
pjfitzgibbons
pushed a commit
that referenced
this pull request
Sep 26, 2023
* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
derek-ho
added a commit
to derek-ho/dashboards-observability
that referenced
this pull request
Oct 4, 2023
…roject#1035) * Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>
pjfitzgibbons
added a commit
that referenced
this pull request
Oct 5, 2023
* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>
amsiglan
pushed a commit
to amsiglan/dashboards-observability
that referenced
this pull request
Jun 7, 2024
* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.