Delete datasource and Connection Configuration Tab by derek-ho · Pull Request #1024 · opensearch-project/dashboards-observability

derek-ho · 2023-09-18T21:12:50Z

Description

This PR does several things:

Address previous PR comments from @pjfitzgibbons
Adds delete functionality on Manage datasource table
Modifies connection details panel according to UX mocks
Adds Connection configuration tab and ability to modify several properties

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Derek Ho <dxho@amazon.com>

…atasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>

codecov · 2023-09-20T17:37:19Z

Codecov Report

Merging #1024 (0dfebea) into feature/flint-UI (28201e9) will increase coverage by 0.05%.
The diff coverage is n/a.

❗ Current head 0dfebea differs from pull request most recent head 9ef64f2. Consider uploading reports for the commit 9ef64f2 to get more accurate results

@@                 Coverage Diff                  @@
##           feature/flint-UI    #1024      +/-   ##
====================================================
+ Coverage             43.87%   43.92%   +0.05%     
====================================================
  Files                   323      326       +3     
  Lines                 18862    18944      +82     
  Branches               4591     4597       +6     
====================================================
+ Hits                   8275     8321      +46     
- Misses                10030    10067      +37     
+ Partials                557      556       -1

Flag	Coverage Δ
dashboards-observability	`43.92% <ø> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 9 files with indirect coverage changes

public/components/data_connections/components/connection_details.tsx

public/components/data_connections/components/manage_data_connections_table.tsx

public/components/data_connections/components/no_access.tsx

Signed-off-by: Derek Ho <dxho@amazon.com>

public/components/data_connections/components/__tests__/testing_constants.ts

public/components/data_connections/components/data_connection.tsx

Signed-off-by: Derek Ho <dxho@amazon.com>

* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Rename and re-organize in folders Signed-off-by: Derek Ho <dxho@amazon.com> * Fix import path in testing file Signed-off-by: Derek Ho <dxho@amazon.com> * Get Initial S3 configuration working Signed-off-by: Derek Ho <dxho@amazon.com> * Configure S3 Data Source Working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix query permissions display Signed-off-by: Derek Ho <dxho@amazon.com> * Fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> * Clean up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Add s3 logo in manage table Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Remove successfully Signed-off-by: Derek Ho <dxho@amazon.com> * Update test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Update test in accordance to useLocation Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Manage datasources (#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Rename and re-organize in folders Signed-off-by: Derek Ho <dxho@amazon.com> * Fix import path in testing file Signed-off-by: Derek Ho <dxho@amazon.com> * Get Initial S3 configuration working Signed-off-by: Derek Ho <dxho@amazon.com> * Configure S3 Data Source Working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix query permissions display Signed-off-by: Derek Ho <dxho@amazon.com> * Fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> * Clean up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Add s3 logo in manage table Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Remove successfully Signed-off-by: Derek Ho <dxho@amazon.com> * Update test Signed-off-by: Derek Ho <dxho@amazon.com> * Initial commit adding prometheus logo and icon Signed-off-by: Derek Ho <dxho@amazon.com> * Get the major flow working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix app navigation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Remove management redirection for now and fix test and add cards Signed-off-by: Derek Ho <dxho@amazon.com> * Remove type filter and update test according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add link and update test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Include useful info in the error toast Signed-off-by: Derek Ho <dxho@amazon.com> * Update actions in manage table according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add update button and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused code until further implementation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix router files Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

…roject#1035) * Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Rename and re-organize in folders Signed-off-by: Derek Ho <dxho@amazon.com> * Fix import path in testing file Signed-off-by: Derek Ho <dxho@amazon.com> * Get Initial S3 configuration working Signed-off-by: Derek Ho <dxho@amazon.com> * Configure S3 Data Source Working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix query permissions display Signed-off-by: Derek Ho <dxho@amazon.com> * Fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> * Clean up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Add s3 logo in manage table Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Remove successfully Signed-off-by: Derek Ho <dxho@amazon.com> * Update test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Update test in accordance to useLocation Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Rename and re-organize in folders Signed-off-by: Derek Ho <dxho@amazon.com> * Fix import path in testing file Signed-off-by: Derek Ho <dxho@amazon.com> * Get Initial S3 configuration working Signed-off-by: Derek Ho <dxho@amazon.com> * Configure S3 Data Source Working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix query permissions display Signed-off-by: Derek Ho <dxho@amazon.com> * Fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> * Clean up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Add s3 logo in manage table Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Remove successfully Signed-off-by: Derek Ho <dxho@amazon.com> * Update test Signed-off-by: Derek Ho <dxho@amazon.com> * Initial commit adding prometheus logo and icon Signed-off-by: Derek Ho <dxho@amazon.com> * Get the major flow working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix app navigation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Remove management redirection for now and fix test and add cards Signed-off-by: Derek Ho <dxho@amazon.com> * Remove type filter and update test according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add link and update test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Include useful info in the error toast Signed-off-by: Derek Ho <dxho@amazon.com> * Update actions in manage table according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add update button and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused code until further implementation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix router files Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

Address previous PR comments and implement rudimentary delete

108c172

Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho requested review from Swiddis, YANG-DB, anirudha, dai-chen, joshuali925, kavithacm, mengweieric, penghuo, pjfitzgibbons, ps48, rupal-bq, seankao-az and vamsimanohar as code owners September 18, 2023 21:12

derek-ho added 2 commits September 20, 2023 11:03

Implement modal and instant delete showing up in list

b766955

Signed-off-by: Derek Ho <dxho@amazon.com>

Refactor save or cancel to a shared component, implement hard coded d…

7570b07

…atasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho changed the title ~~Address previous PR comments and implement rudimentary delete~~ Delete datasource and Connection Configuration Tabs Sep 20, 2023

derek-ho changed the title ~~Delete datasource and Connection Configuration Tabs~~ Delete datasource and Connection Configuration Tab Sep 20, 2023

Update test with mock role data

e861b8c

Signed-off-by: Derek Ho <dxho@amazon.com>

pjfitzgibbons reviewed Sep 20, 2023

View reviewed changes

Add most functionality of edit connectiondetails

0dfebea

Signed-off-by: Derek Ho <dxho@amazon.com>

ps48 reviewed Sep 20, 2023

View reviewed changes

public/components/data_connections/components/__tests__/testing_constants.ts Show resolved Hide resolved

ps48 reviewed Sep 20, 2023

View reviewed changes

public/components/data_connections/components/data_connection.tsx Outdated Show resolved Hide resolved

Address PR comments

9ef64f2

Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho force-pushed the delete branch from 886a226 to 9ef64f2 Compare September 20, 2023 21:05

derek-ho merged commit 89eafa2 into opensearch-project:feature/flint-UI Sep 20, 2023

derek-ho deleted the delete branch September 20, 2023 21:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete datasource and Connection Configuration Tab#1024

Delete datasource and Connection Configuration Tab#1024
derek-ho merged 6 commits intoopensearch-project:feature/flint-UIfrom
derek-ho:delete

derek-ho commented Sep 18, 2023 •

edited

Loading

Uh oh!

codecov bot commented Sep 20, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

derek-ho commented Sep 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues Resolved

Check List

Uh oh!

codecov bot commented Sep 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

derek-ho commented Sep 18, 2023 •

edited

Loading

codecov bot commented Sep 20, 2023 •

edited

Loading