-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Refactor workspace form UI #7133
[Workspace]Refactor workspace form UI #7133
Conversation
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7133 +/- ##
==========================================
+ Coverage 67.56% 67.61% +0.05%
==========================================
Files 3469 3471 +2
Lines 68479 68576 +97
Branches 11130 11155 +25
==========================================
+ Hits 46266 46368 +102
+ Misses 19511 19507 -4
+ Partials 2702 2701 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
}); | ||
const disabledUserOrGroupInputIdsRef = useRef( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should it use useMemo
so that the computed id list will update when defaultValues.permissionSettings
changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is by intentionally. The defaultValues
should not be changed after workspace form component mount. It's not reflect to the form values. It's not reflect to the latest form values. We need to use these default values to disable the user or group selector .
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
Signed-off-by: Lin Wang <[email protected]>
* Make create workspace and update workspace full width Signed-off-by: Lin Wang <[email protected]> * Refactor user permissions input Signed-off-by: Lin Wang <[email protected]> * Add workspace form call out Signed-off-by: Lin Wang <[email protected]> * Fix permissions input unit tests Signed-off-by: Lin Wang <[email protected]> * Update gaps Signed-off-by: Lin Wang <[email protected]> * Update error callout Signed-off-by: Lin Wang <[email protected]> * Update user permission current user and number of changes Signed-off-by: Lin Wang <[email protected]> * Fix changes Signed-off-by: Lin Wang <[email protected]> * Fix owner order Signed-off-by: Lin Wang <[email protected]> * Add ut for form error callout Signed-off-by: Lin Wang <[email protected]> * Fix unit tests in workspace Signed-off-by: Lin Wang <[email protected]> * Mark first user row required Signed-off-by: Lin Wang <[email protected]> * Update section title Signed-off-by: Lin Wang <[email protected]> * Add validate for owner missing Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7133 created/updated * Fix unit tests for workspace form utils Signed-off-by: Lin Wang <[email protected]> * Fix unit tests for form error callout Signed-off-by: Lin Wang <[email protected]> * Add unit test for transfer current user placeholder Signed-off-by: Lin Wang <[email protected]> * Fix unit tests in workspace permission setting panel Signed-off-by: Lin Wang <[email protected]> * Fix unit test in useWorkspaceForm Signed-off-by: Lin Wang <[email protected]> * Add missing unit tests for workspace form utils Signed-off-by: Lin Wang <[email protected]> * Add unit tests for getNumberOfErrors Signed-off-by: Lin Wang <[email protected]> * Add more ut for workspace form error callout Signed-off-by: Lin Wang <[email protected]> * Fix error code Signed-off-by: Lin Wang <[email protected]> * Fix failed unit test Signed-off-by: Lin Wang <[email protected]> * Add back color picker Signed-off-by: Lin Wang <[email protected]> * Address UX comments Signed-off-by: Lin Wang <[email protected]> * Fix empty user no workspace owner Signed-off-by: Lin Wang <[email protected]> * Change to Associate data source Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c5946b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Make create workspace and update workspace full width * Refactor user permissions input * Add workspace form call out * Fix permissions input unit tests * Update gaps * Update error callout * Update user permission current user and number of changes * Fix changes * Fix owner order * Add ut for form error callout * Fix unit tests in workspace * Mark first user row required * Update section title * Add validate for owner missing * Changeset file for PR #7133 created/updated * Fix unit tests for workspace form utils * Fix unit tests for form error callout * Add unit test for transfer current user placeholder * Fix unit tests in workspace permission setting panel * Fix unit test in useWorkspaceForm * Add missing unit tests for workspace form utils * Add unit tests for getNumberOfErrors * Add more ut for workspace form error callout * Fix error code * Fix failed unit test * Add back color picker * Address UX comments * Fix empty user no workspace owner * Change to Associate data source --------- (cherry picked from commit c5946b9) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
This PR includes a bunch of UI updates about the workspace form. Mainly includes below changes:
Issues Resolved
#7190
Screenshot
Screen.Recording.2024-07-11.at.11.37.55.mov
Screen.Recording.2024-07-11.at.11.40.49.mov
Testing the changes
yarn osd bootstrap
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration