[Backport 2.x] [Workspace]Refactor workspace form UI #7227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Make create workspace and update workspace full width Signed-off-by: Lin Wang <[email protected]> * Refactor user permissions input Signed-off-by: Lin Wang <[email protected]> * Add workspace form call out Signed-off-by: Lin Wang <[email protected]> * Fix permissions input unit tests Signed-off-by: Lin Wang <[email protected]> * Update gaps Signed-off-by: Lin Wang <[email protected]> * Update error callout Signed-off-by: Lin Wang <[email protected]> * Update user permission current user and number of changes Signed-off-by: Lin Wang <[email protected]> * Fix changes Signed-off-by: Lin Wang <[email protected]> * Fix owner order Signed-off-by: Lin Wang <[email protected]> * Add ut for form error callout Signed-off-by: Lin Wang <[email protected]> * Fix unit tests in workspace Signed-off-by: Lin Wang <[email protected]> * Mark first user row required Signed-off-by: Lin Wang <[email protected]> * Update section title Signed-off-by: Lin Wang <[email protected]> * Add validate for owner missing Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #7133 created/updated * Fix unit tests for workspace form utils Signed-off-by: Lin Wang <[email protected]> * Fix unit tests for form error callout Signed-off-by: Lin Wang <[email protected]> * Add unit test for transfer current user placeholder Signed-off-by: Lin Wang <[email protected]> * Fix unit tests in workspace permission setting panel Signed-off-by: Lin Wang <[email protected]> * Fix unit test in useWorkspaceForm Signed-off-by: Lin Wang <[email protected]> * Add missing unit tests for workspace form utils Signed-off-by: Lin Wang <[email protected]> * Add unit tests for getNumberOfErrors Signed-off-by: Lin Wang <[email protected]> * Add more ut for workspace form error callout Signed-off-by: Lin Wang <[email protected]> * Fix error code Signed-off-by: Lin Wang <[email protected]> * Fix failed unit test Signed-off-by: Lin Wang <[email protected]> * Add back color picker Signed-off-by: Lin Wang <[email protected]> * Address UX comments Signed-off-by: Lin Wang <[email protected]> * Fix empty user no workspace owner Signed-off-by: Lin Wang <[email protected]> * Change to Associate data source Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit c5946b9) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7227 +/- ##
==========================================
+ Coverage 67.66% 67.71% +0.05%
==========================================
Files 3450 3452 +2
Lines 68148 68245 +97
Branches 11069 11094 +25
==========================================
+ Hits 46111 46215 +104
+ Misses 19362 19357 -5
+ Partials 2675 2673 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
approved these changes
Jul 16, 2024
ruanyl
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c5946b9 from #7133.