Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workspace failed integration tests #1442

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Fix workspace failed integration tests #1442

merged 1 commit into from
Jul 19, 2024

Conversation

wanglam
Copy link
Collaborator

@wanglam wanglam commented Jul 16, 2024 •
edited
Loading

Description

Due to workspace form refactor PR in OSD, some workspace integration test cases were failed across below files:

  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_create.spec.js
  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_import_sample_data_to.spec.js
  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_overview.spec.js
  • cypress/integration/core-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_update.spec.js

This PR aim to fix these failed test cases.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@wanglam wanglam force-pushed the fix-workspace-integration-test-failed branch from 63a6d9e to 41bd900 Compare July 16, 2024 08:29
@wanglam wanglam merged commit 25f947d into opensearch-project:main Jul 19, 2024
53 of 63 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 19, 2024
@wanglam @github-actions
Fix workspace failed integration tests (#1442)
4165b5c 
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 25f947d)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 19, 2024
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 29, 2024
@wanglam @github-actions
Fix workspace failed integration tests (#1442)
2d692bc 
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 25f947d)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 29, 2024
Merged
SuZhou-Joe pushed a commit that referenced this pull request Jul 31, 2024
@opensearch-trigger-bot @wanglam
Fix workspace failed integration tests (#1442) (#1445)
32e25f9 
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 25f947d)

Co-authored-by: Lin Wang <[email protected]>
SuZhou-Joe added a commit that referenced this pull request Jul 31, 2024
@opensearch-trigger-bot @wanglam @SuZhou-Joe
Fix workspace failed integration tests (#1442) (#1450)
cd008d1 
Signed-off-by: Lin Wang <[email protected]>
(cherry picked from commit 25f947d)

Co-authored-by: Lin Wang <[email protected]>
Co-authored-by: SuZhou-Joe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@raintygao raintygao raintygao approved these changes

@tianleh tianleh Awaiting requested review from tianleh tianleh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@CCongWang CCongWang Awaiting requested review from CCongWang CCongWang is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@peterzhuamazon peterzhuamazon Awaiting requested review from peterzhuamazon peterzhuamazon is a code owner

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@prudhvigodithi prudhvigodithi Awaiting requested review from prudhvigodithi prudhvigodithi is a code owner

@xluo-aws xluo-aws Awaiting requested review from xluo-aws xluo-aws is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@yujin-emma yujin-emma Awaiting requested review from yujin-emma yujin-emma is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.16 v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wanglam @raintygao @Hailong-am @SuZhou-Joe