[Chat] Refactor chat architecture: Extract shared infrastructure into a core chat service#10983
Merged
ananzh merged 4 commits intoopensearch-project:mainfrom Dec 3, 2025
Merged
Conversation
WalkthroughCentralizes chat infrastructure into a new core ChatService with observable thread/window state and public types; refactors the chat plugin to delegate to core services; introduces ML agent routing abstractions with AG‑UI fallback; removes several chart visualization error-handling modules and updates numerous tests and integrations. Changes
Sequence DiagramsequenceDiagram
actor Plugin as Chat Plugin
participant Core as CoreSystem
participant ChatSvc as ChatService (core)
participant Impl as Plugin Implementation
participant MLRouter as MLAgentRouter / AG-UI
Note over Core,ChatSvc: Setup & Start
Plugin->>Core: setup(core)
Core->>ChatSvc: instantiate ChatService
Core->>ChatSvc: start()
ChatSvc-->>Core: ChatServiceStart (public contract)
Note over Plugin,Impl: Runtime messaging flow
Plugin->>ChatSvc: sendMessage(content, messages)
alt Implementation registered
ChatSvc->>Impl: sendMessage(content, messages)
Impl-->>ChatSvc: { observable, userMessage }
ChatSvc-->>Plugin: resolve with userMessage and observable
else No implementation
ChatSvc-->>Plugin: reject "Chat plugin not enabled"
end
Note over ChatSvc,MLRouter: Server-side agent routing (when triggering agent)
ChatSvc->>MLRouter: forward request (includes dataSourceId)
alt ML router available
MLRouter-->>ChatSvc: streaming or JSON response
else Fallback
ChatSvc->>MLRouter: forwardToAgUI proxy
MLRouter-->>ChatSvc: streaming SSE response
end
Note over Core,ChatSvc: Window state
Plugin->>ChatSvc: setWindowState({isWindowOpen:true})
ChatSvc->>ChatSvc: update windowState$ -> emit
ChatSvc->>Plugin: invoke onWindowOpen callbacks
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 YAMLlint (1.37.1)changelogs/fragments/10983.yml[error] 2-2: syntax error: expected , but found '' (syntax) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (67)
Comment |
Contributor
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10983 +/- ##
==========================================
- Coverage 60.79% 60.77% -0.02%
==========================================
Files 4531 4537 +6
Lines 122262 122381 +119
Branches 20501 20535 +34
==========================================
+ Hits 74325 74376 +51
- Misses 42695 42748 +53
- Partials 5242 5257 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ananzh
force-pushed
the
refactor-chat
branch
2 times, most recently
from
2ed2cbd to
79000d0
Compare
wanglam
reviewed
Nov 27, 2025
| ], | ||
| "requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard"], | ||
| "optionalPlugins": ["home", "share", "chat", "contextProvider", "datasetManagement"], | ||
| "requiredBundles": ["opensearchDashboardsReact", "opensearchDashboardsUtils", "dashboard", "dataSource"], |
Collaborator
There was a problem hiding this comment.
It seems dataSource isn't being used in the explore plugin. Can we remove this dependency?
ananzh
force-pushed
the
refactor-chat
branch
from
79000d0 to
12b745b
Compare
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
ananzh
force-pushed
the
refactor-chat
branch
2 times, most recently
from
c9d0b03 to
7c8fc22
Compare
ananzh
changed the title
Contributor
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
ananzh
changed the title
Contributor
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
1 similar comment
Contributor
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
ananzh
requested review from
AMoo-Miki,
Flyingliuhub,
ZilongX,
abbyhu2000,
ashwin-pc,
curq,
joshuarrrr,
kavilla,
manasvinibs,
zengyan-amazon and
zhongnansu
as code owners
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Dec 1, 2025
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
♻️ Duplicate comments (1)
src/core/public/chat/chat_service.ts (1)
39-51:suggestedActionsServicein setup contract still capturesundefinedat call time.Line 49 returns
suggestedActionsService: this.suggestedActionsServicewhich evaluates toundefinedwhensetup()is called, beforesetSuggestedActionsServicehas been invoked. Consumers accessing it from the setup contract will always getundefined.The fix in the start contract (line 157-159) correctly uses a getter. Apply the same pattern here:
public setup(): ChatServiceSetup { return { setImplementation: (implementation: ChatImplementationFunctions) => { this.implementation = implementation; }, setSuggestedActionsService: (service: { registerProvider(provider: any): void }) => { this.suggestedActionsService = service; }, - suggestedActionsService: this.suggestedActionsService, + get suggestedActionsService() { + return chatServiceInstance.suggestedActionsService; + }, }; }Note: You'll need to capture
thisreference (e.g.,const chatServiceInstance = this;) before the return statement, similar to how it's done instart().
🧹 Nitpick comments (10)
src/plugins/chat/public/components/chat_window.tsx (1)
139-163: Consider extracting shared subscription logic.The subscription handling in
handleSend(lines 140-157) andhandleResendMessage(lines 211-228) are nearly identical. Consider extracting this into a helper function to reduce duplication.Also, the returned cleanup function
() => subscription.unsubscribe()is not used by callers sincehandleSendis called without storing the result. Either remove the return or ensure callers use the cleanup when needed.src/core/public/chat/chat_service.ts (2)
163-168: Complete BehaviorSubjects instop()to properly signal lifecycle end.The
threadId$andwindowState$BehaviorSubjects are not completed instop(). While this may not cause immediate issues since the service stops with the application, completing them ensures subscribers receive proper lifecycle notifications and prevents potential memory leaks if subscribers don't explicitly unsubscribe.public async stop() { this.implementation = undefined; this.suggestedActionsService = undefined; this.windowOpenCallbacks.clear(); this.windowCloseCallbacks.clear(); + this.threadId$.complete(); + this.windowState$.complete(); }
111-132: Clarify the callback-based window control pattern.
openWindow()andcloseWindow()trigger callbacks without directly updatingwindowState. This design delegates state management to the UI layer (which callssetWindowState). While this is intentional, consider adding a brief comment explaining this indirection to help future maintainers understand the flow.src/core/public/chat/types.ts (2)
71-77:ToolMessagedoesn't extendBaseMessageunlike other message types.All other message types (
DeveloperMessage,SystemMessage,AssistantMessage,UserMessage) extendBaseMessage, butToolMessageredefinesid,content, androledirectly. While this works due to structural typing, extendingBaseMessagewould be more consistent and ensureToolMessageinherits any future additions toBaseMessage(likename).-export interface ToolMessage { - id: string; - content: string; +export interface ToolMessage extends BaseMessage { role: 'tool'; + content: string; toolCallId: string; error?: string; }
135-143: Consider typing theobservablereturn value more specifically.Using
observable: anyin the return types (lines 138, 154, 160) loses type safety. If the observable emitsChatEventfrom../../common/events, consider typing it asObservable<ChatEvent>or defining an appropriate event union type. This would help consumers understand the expected event stream.sendMessage( content: string, messages: Message[] - ): Promise<{ observable: any; userMessage: UserMessage }>; + ): Promise<{ observable: Observable<ChatEvent>; userMessage: UserMessage }>;src/plugins/chat/public/components/chat_header_button.tsx (1)
61-79: Good defensive coding with guard and try/catch.Adding the early return when
flyoutMountPoint.currentis unavailable and wrappingsidecar.openin try/catch prevents potential runtime errors. However, the catch block silently returns without logging, which could make debugging difficult.Consider logging the error for debugging purposes:
} catch (error) { + console.warn('Failed to open sidecar:', error); return; }src/core/public/chat/chat_service.mock.ts (1)
15-48: Align mock observables and defaults with realChatServicebehavior
getThreadId$/getWindowState$each instantiate a newBehaviorSubject, andgetThreadIdreturns an empty string. In the realChatService, these are shared subjects with generatedthread-*IDs and a single window state stream. Tests that rely on shared state, ID format, or subscription behavior might see discrepancies when swapping between real and mock services.Consider:
- Reusing a single
BehaviorSubjectinstance per mock for thread ID and window state, and- Initializing the thread ID with a
thread-${timestamp}-${random}pattern similar to the core service,so the mock more faithfully mirrors production behavior.
src/plugins/chat/public/plugin.ts (1)
50-82: Guard against writingpaddingSize: undefinedinto window state
setupChatbotWindowStatesubscribes tooverlays.sidecar.getSidecarConfig$()and forwardspaddingSizedirectly tothis.chatService.setWindowState({ paddingSize }). WhenpaddingSizeisundefined, this overwrites the core window state with an undefined value, relying on later readers to fall back to400.To avoid muddying the core state, consider only updating when a concrete value is present:
.subscribe((paddingSize) => { if (paddingSize != null) { this.chatService?.setWindowState({ paddingSize }); } });This keeps the core window state canonical while still reacting to valid sidecar padding updates.
src/plugins/chat/public/services/chat_service.test.ts (1)
243-347: Consider stubbingconsole.warnaround tests that expect nouiSettingsThese tests intentionally construct
ChatServicewithoutuiSettingsand assert thatrunAgentis called with adataSourceIdofundefined. The implementation logs aconsole.warnin that case viagetWorkspaceAwareDataSourceId, so these specs will emit warnings in CI even though the behavior is expected.You might want to stub
console.warnin the relevant suites (or in a shared Jest setup) to keep test output clean while still validating the same behavior.Also applies to: 350-394
src/plugins/chat/public/services/chat_service.ts (1)
67-79: CentralizecoreChatServicenull-checking for clarityMost public methods (
getThreadId,getThreadId$, window state accessors, window event hooks,openWindow/closeWindow,newThread, persistence viagetThreadId) begin with the same guard:if (!this.coreChatService) { throw new Error('Core chat service not available'); }Given that
ChatServiceis only intended to be used with a validChatServiceStart(as in the plugin), you could:
- Enforce a non-optional constructor parameter for
coreChatService, or- Introduce a small helper like
private getCore(): ChatServiceStartto perform the check once.This removes repetition and makes the invariant (“core chat must exist”) explicit at the type or helper level.
Also applies to: 102-115, 117-139, 141-170, 172-184, 195-207, 435-447, 497-503
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (16)
src/core/public/chat/chat_service.mock.ts(1 hunks)src/core/public/chat/chat_service.test.ts(1 hunks)src/core/public/chat/chat_service.ts(1 hunks)src/core/public/chat/types.ts(1 hunks)src/plugins/chat/public/components/chat_header_button.tsx(5 hunks)src/plugins/chat/public/components/chat_window.tsx(5 hunks)src/plugins/chat/public/components/graph_visualization/error_boundary.tsx(0 hunks)src/plugins/chat/public/components/graph_visualization/error_display.tsx(0 hunks)src/plugins/chat/public/components/graph_visualization/error_handler.ts(0 hunks)src/plugins/chat/public/components/graph_visualization/validation.ts(0 hunks)src/plugins/chat/public/plugin.test.ts(4 hunks)src/plugins/chat/public/plugin.ts(5 hunks)src/plugins/chat/public/services/chat_context_manager.test.ts(0 hunks)src/plugins/chat/public/services/chat_context_manager.ts(0 hunks)src/plugins/chat/public/services/chat_service.test.ts(16 hunks)src/plugins/chat/public/services/chat_service.ts(15 hunks)
💤 Files with no reviewable changes (6)
- src/plugins/chat/public/components/graph_visualization/validation.ts
- src/plugins/chat/public/services/chat_context_manager.ts
- src/plugins/chat/public/components/graph_visualization/error_handler.ts
- src/plugins/chat/public/components/graph_visualization/error_boundary.tsx
- src/plugins/chat/public/services/chat_context_manager.test.ts
- src/plugins/chat/public/components/graph_visualization/error_display.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- src/core/public/chat/chat_service.test.ts
🧰 Additional context used
🧬 Code graph analysis (7)
src/plugins/chat/public/components/chat_header_button.tsx (1)
src/core/public/index.ts (1)
SIDECAR_DOCKED_MODE(229-229)
src/core/public/chat/chat_service.mock.ts (1)
src/core/public/chat/types.ts (2)
ChatServiceSetup(170-190)ChatServiceStart(195-203)
src/plugins/chat/public/components/chat_window.tsx (2)
src/core/public/chat/types.ts (1)
Message(82-87)src/plugins/chat/common/types.ts (1)
Message(12-12)
src/plugins/chat/public/plugin.ts (4)
src/core/public/index.ts (2)
CoreSetup(262-298)CoreStart(321-358)src/core/public/chat/chat_service.ts (1)
ChatService(19-169)src/plugins/chat/public/services/chat_service.ts (1)
ChatService(36-510)src/core/public/chat/index.ts (1)
ChatService(23-23)
src/plugins/chat/public/plugin.test.ts (2)
src/core/public/chat/chat_service.ts (1)
ChatService(19-169)src/plugins/chat/public/plugin.ts (1)
ChatPlugin(41-192)
src/core/public/chat/chat_service.ts (1)
src/core/public/chat/types.ts (5)
ChatServiceSetup(170-190)ChatServiceStart(195-203)ChatImplementationFunctions(149-165)ChatWindowState(97-101)Message(82-87)
src/plugins/chat/public/services/chat_service.test.ts (2)
src/core/public/chat/chat_service.ts (1)
ChatService(19-169)src/core/public/chat/types.ts (1)
ChatServiceStart(195-203)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (68)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Lint and validate
- GitHub Check: lighthouse
- GitHub Check: WhiteSource Security Check
🔇 Additional comments (8)
src/plugins/chat/public/components/chat_window.tsx (2)
67-83: Good use of ref pattern to stabilize timeline access in memoized callback.The
timelineRefpattern correctly avoids stale closure issues by providing access to the latesttimelinevalue inside the memoizedeventHandlerwithout forcing re-creation on every timeline change.
31-34: LGTM!The
ChatWindowInstanceinterface correctly exposessendMessagealongsidestartNewChat, enabling external callers to programmatically send messages through the chat window ref.src/core/public/chat/types.ts (1)
1-93: Well-structured message type system.The discriminated union pattern for
Messagetypes with role-based discrimination is a solid design. TheRoletype correctly enumerates all valid roles. This provides good type safety for message handling throughout the chat system.src/plugins/chat/public/components/chat_header_button.tsx (2)
153-170: LGTM!Using
chatService.isWindowOpen()instead of the localisOpenstate in the window open/close request handlers ensures consistency with the authoritative state source. The dependency array correctly reflects the actual dependencies used in the callbacks.
193-198: LGTM!The availability check using
core.chat.isAvailable()correctly gates the entire chat UI when the chat service is unavailable, aligning with the core-driven enablement model described in the PR objectives.src/plugins/chat/public/plugin.test.ts (3)
41-45: LGTM!Adding the
capabilitiesmock withagenticFeaturesEnabled: trueproperly enables the chat feature in tests, aligning with the unified enablement model where the core service drives feature availability decisions.
93-95: LGTM!The updated assertion correctly verifies that
ChatServiceis constructed withuiSettingsandchatfrom the core start contract, aligning with the new constructor signature that injects core dependencies.
180-189: LGTM!The test correctly verifies that
ChatServiceis always initialized regardless of configuration, with the core service handling enablement decisions. Removing the unused index parameter is a good cleanup.
Comment on lines
+258
to
+294
| /** | ||
| * Get workspace-aware data source ID | ||
| * Determines the correct data source based on current workspace context | ||
| */ | ||
| private async getWorkspaceAwareDataSourceId(): Promise<string | undefined> { | ||
| try { | ||
| if (!this.uiSettings) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('UI Settings not available, using default data source'); | ||
| return undefined; | ||
| } | ||
|
|
||
| // Get workspace context | ||
| const workspaces = getWorkspaces(); | ||
| if (!workspaces) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('Workspaces service not available, using global scope'); | ||
| return undefined; | ||
| } | ||
|
|
||
| const currentWorkspaceId = workspaces.currentWorkspaceId$.getValue(); | ||
|
|
||
| // Determine scope based on workspace context | ||
| const scope: UiSettingScope = !!currentWorkspaceId | ||
| ? UiSettingScope.WORKSPACE | ||
| : UiSettingScope.GLOBAL; | ||
|
|
||
| // Get default data source with proper scope | ||
| const dataSourceId = await getDefaultDataSourceId(this.uiSettings, scope); | ||
|
|
||
| return dataSourceId || undefined; | ||
| } catch (error) { | ||
| // eslint-disable-next-line no-console | ||
| console.warn('Failed to determine workspace-aware data source, proceeding without:', error); | ||
| return undefined; // Graceful fallback - undefined means local cluster | ||
| } | ||
| } |
There was a problem hiding this comment.
getWorkspaceAwareDataSourceId skips global default when workspaces are unavailable
In the !workspaces branch you log:
console.warn('Workspaces service not available, using global scope');
return undefined;However, returning undefined bypasses getDefaultDataSourceId entirely, so in non-workspace environments you effectively ignore any configured global default data source and always fall back to the local cluster. That’s different from the workspace-enabled path, where the global default is honored via UiSettingScope.GLOBAL.
To keep behavior consistent (and match the log message), consider:
const workspaces = getWorkspaces();
if (!workspaces) {
// eslint-disable-next-line no-console
console.warn('Workspaces service not available, using global scope');
const dataSourceId = await getDefaultDataSourceId(this.uiSettings, UiSettingScope.GLOBAL);
return dataSourceId || undefined;
}This way, workspace-less deployments still respect the configured global default data source.
🤖 Prompt for AI Agents
In src/plugins/chat/public/services/chat_service.ts around lines 258 to 294, the
branch handling !workspaces returns undefined which skips calling
getDefaultDataSourceId and therefore ignores any configured GLOBAL default;
instead, call getDefaultDataSourceId(this.uiSettings, UiSettingScope.GLOBAL) in
that branch, return its result (or undefined if falsy), and keep the
console.warn message so non-workspace deployments still honor the global default
data source.
7 tasks
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Dec 1, 2025
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (2)
9-47: Consider reusing the core chat service start mock instead of hand‑rolledjest.Mocked<ChatServiceStart>The manual
mockChatServiceshape looks consistent with the currentChatServiceStartsurface, but it will need to be kept in sync as the core chat API evolves. Since this PR adds a dedicated core chat mock module (src/core/public/chat/chat_service.mock.ts), it would be more maintainable to construct the mock from that shared helper and only override the behaviors you care about in this test (e.g.,sendMessageWithWindow,isWindowOpen).This reduces duplication and the risk of missing new methods in future refactors.
172-220: Double‑check the semantics of the second argument tosendMessageWithWindowThe updated expectations now assert that
sendMessageWithWindowis always called with an empty array as the second argument:
- Line 189–192:
'What is this error?', []- Line 215–218:
'Follow-up question', []- Line 265:
'Test question', []If that second parameter is intended to carry tool results, context payload, or other metadata in the new core chat API, enforcing
[]here might be too strict and could mask missing context fromAskAIActionItem. Conversely, if this component is intentionally not providing any additional payload, you might want to either:
- keep the assertion but add a short comment clarifying that
[]is the expected contract for this call site, or- relax the assertion to only care about the message (e.g.,
toHaveBeenCalledWith('What is this error?', expect.any(Array))orexpect.anything()), so tests don’t over‑couple to how the second argument is currently used.Please confirm that
[]is the correct, long‑term behavior for this component with the newChatServiceStartsignature.Also applies to: 265-265
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/plugins/dashboard/public/application/components/dashboard_top_nav/__snapshots__/dashboard_top_nav.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (2)
src/core/public/chat/chat_service.test.ts(1 hunks)src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx(7 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/core/public/chat/chat_service.test.ts
🧰 Additional context used
🧬 Code graph analysis (1)
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (2)
src/core/public/chat/types.ts (1)
ChatServiceStart(195-203)src/core/public/index.ts (1)
ChatServiceStart(440-440)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (68)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: lighthouse
- GitHub Check: bundle-analyzer
- GitHub Check: WhiteSource Security Check
opensearch-changeset-bot bot
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Dec 2, 2025
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
src/plugins/chat/public/services/chat_service.ts (1)
265-301:getWorkspaceAwareDataSourceIdstill bypasses global default when workspaces unavailable.This issue was flagged in a previous review. When
!workspaces(lines 279-283), the code returnsundefinedwithout callinggetDefaultDataSourceIdwithUiSettingScope.GLOBAL. This means non-workspace deployments won't respect the configured global default data source.Consider calling
getDefaultDataSourceIdwith global scope when workspaces are unavailable:const workspaces = this.workspaces; if (!workspaces) { // eslint-disable-next-line no-console console.warn('Workspaces service not available, using global scope'); - return undefined; + const dataSourceId = await getDefaultDataSourceId(this.uiSettings, UiSettingScope.GLOBAL); + return dataSourceId || undefined; }
🧹 Nitpick comments (2)
src/plugins/chat/public/plugin.ts (1)
114-129: Consider null-safe optional chaining forthis.chatService.The code uses
this.chatService.sendMessage.bind(this.chatService)after the!isEnabledearly return, sothis.chatServiceis guaranteed to be defined at this point. However, usingthis.chatService!would make this explicit to readers and align with usage on lines 141 and 177.// Register implementation functions with core chat service if (this.coreSetup?.chat?.setImplementation) { this.coreSetup.chat.setImplementation({ // Only business logic operations - sendMessage: this.chatService.sendMessage.bind(this.chatService), - sendMessageWithWindow: this.chatService.sendMessageWithWindow.bind(this.chatService), - openWindow: this.chatService.openWindow.bind(this.chatService), - closeWindow: this.chatService.closeWindow.bind(this.chatService), + sendMessage: this.chatService!.sendMessage.bind(this.chatService!), + sendMessageWithWindow: this.chatService!.sendMessageWithWindow.bind(this.chatService!), + openWindow: this.chatService!.openWindow.bind(this.chatService!), + closeWindow: this.chatService!.closeWindow.bind(this.chatService!), }); }src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (1)
9-9: Mock now correctly targets coreChatServiceStart; consider reusing shared mock helperThe switch to importing
ChatServiceStartfromcore/publicand typingmockChatServiceasjest.Mocked<ChatServiceStart>with the expanded method surface (sendMessageWithWindow, window state APIs,suggestedActionsService) looks consistent with the new core chat service contract.To reduce duplication and keep this mock in sync with future API changes, you might consider constructing it via the new core chat mock helper (e.g., from
src/core/public/chat/chat_service.mock.ts) instead of hand-rolling the object here.Also applies to: 26-26, 35-47
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/plugins/dashboard/public/application/components/dashboard_top_nav/__snapshots__/dashboard_top_nav.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (5)
src/core/public/chat/chat_service.test.ts(1 hunks)src/plugins/chat/public/plugin.test.ts(5 hunks)src/plugins/chat/public/plugin.ts(5 hunks)src/plugins/chat/public/services/chat_service.ts(15 hunks)src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx(7 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/core/public/chat/chat_service.test.ts
🧰 Additional context used
🧬 Code graph analysis (3)
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (1)
src/core/public/chat/types.ts (1)
ChatServiceStart(195-203)
src/plugins/chat/public/plugin.test.ts (2)
src/core/public/chat/chat_service.ts (1)
ChatService(19-169)src/plugins/chat/public/plugin.ts (1)
ChatPlugin(41-192)
src/plugins/chat/public/services/chat_service.ts (4)
src/core/public/index.ts (5)
IUiSettingsClient(399-399)ChatServiceStart(440-440)WorkspacesStart(421-421)ChatWindowState(443-443)UiSettingScope(142-142)src/core/public/chat/types.ts (2)
ChatServiceStart(195-203)ChatWindowState(97-101)src/core/public/chat/index.ts (2)
ChatServiceStart(9-9)ChatWindowState(20-20)src/plugins/data_source_management/public/index.ts (1)
getDefaultDataSourceId(29-29)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (68)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: WhiteSource Security Check
- GitHub Check: lighthouse
- GitHub Check: bundle-analyzer
🔇 Additional comments (15)
src/plugins/chat/public/plugin.test.ts (4)
41-62: Mock setup correctly includes new core services.The mock setup properly adds
capabilities.investigation.agenticFeaturesEnabled,uiSettings,chat, andworkspacesto align with the refactored ChatService constructor and enablement flow. Using empty objects for these mocks is acceptable for unit tests that only verify constructor call arguments.
96-101: Constructor expectation correctly updated.The test now verifies that
ChatServiceis instantiated with the three core dependencies (uiSettings,chat,workspaces) frommockCoreStart, matching the new constructor signature.
137-147: Test description accurately reflects new enablement semantics.The updated test description "should always initialize chat service (core service handles enablement)" correctly documents that the plugin always initializes ChatService and defers enablement decisions to the core service.
195-208: Configuration handling test updated for core-driven enablement.The loop correctly tests various configuration formats and verifies that
ChatServiceis always instantiated with the three core dependencies, regardless of the config values. The comment on line 202 accurately explains that enablement logic is delegated to the core service.src/plugins/chat/public/plugin.ts (3)
12-24: Imports correctly updated for core integration.The new imports properly bring in
CoreSetup,ChatWindowStatefrom core, andisChatEnabledfrom the common capabilities module to support the refactored architecture.
84-91: Setup method signature updated for core integration.The
setupmethod now acceptsCoreSetupand stores the reference for later use instart(). This follows the OpenSearch Dashboards plugin lifecycle pattern where setup captures references needed during start.
93-112: Unified enablement check with graceful fallback.The enablement logic using
isChatEnabled()centralizes the decision. Note thatChatServiceis always instantiated on line 106 (before the enablement check), but the return contract correctly returnschatService: undefinedwhen disabled. This ensures internal state is consistent even when chat is disabled.src/plugins/chat/public/services/chat_service.ts (5)
54-72: Constructor properly initializes dependencies and restores state.The constructor correctly stores the three dependencies and conditionally restores thread ID from session storage only when
coreChatServiceis available. This prevents errors during initialization when the core service is not provided.
148-177: Change tracking inonWindowStateChangeis well-implemented.The implementation correctly:
- Skips the initial state to avoid spurious callbacks
- Compares previous vs new state to determine what changed
- Only notifies when something actually changed
- Properly unsubscribes on cleanup
This is a clean pattern for observing state changes with change metadata.
488-502: Guard clause improvement inclearDynamicContextFromStore.Good refactor using early return pattern instead of nested conditionals. This improves readability.
504-516:newThreadcorrectly delegates to core service.The method properly delegates thread creation to
coreChatService, clears local messages, removes session storage, and clears dynamic context. The error thrown whencoreChatServiceis unavailable maintains consistency with other methods.
74-86: Throwing on missing core service may cause runtime issues.These methods throw
Error('Core chat service not available')whencoreChatServiceis undefined. While this enforces the dependency contract, callers (UI components, other services) must properly handle these exceptions. Verify that all callers either:
- Are only invoked when chat is enabled (and thus
coreChatServiceis available), or- Have proper try/catch error handling
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (3)
172-194: Execution test asserts the updatedsendMessageWithWindowcontract correctlyThe “should send message with sendMessageWithWindow” test now verifies the two-argument call (
message,[]), which matches the updated payload contract and gives good coverage that the component isn’t leaking any extra context through this path.
196-220: Good coverage for behavior when chat window is already openThe new “should send message regardless of chat window state” test correctly stubs
isWindowOpentotrueand still asserts asendMessageWithWindow(message, [])call, guarding against regressions where an open window might inadvertently short-circuit sending.
248-267: Trim test validates outbound message normalization against the new APIThe whitespace-trimming test now asserts
sendMessageWithWindow('Test question', []), which both validates input normalization and confirms the component uses the new empty-payload shape consistently with other execution tests.
wanglam
previously approved these changes
Dec 2, 2025
| navigation: NavigationPublicPluginStart; | ||
| contextProvider: ContextProviderStart; | ||
| charts: ChartsPluginStart; | ||
| dataSourceManagement?: DataSourceManagementPluginSetup; |
Collaborator
There was a problem hiding this comment.
Nit: Seems we don't rely on the dataSourceManagement plugin for now, can we remove it from the dependencies and the opensearch_dashboards.json. I'm open to do this in the future PR.
Member
Author
There was a problem hiding this comment.
Yes will completely clean it out
SuZhou-Joe
reviewed
Dec 2, 2025
| return this.windowState$.asObservable(); | ||
| }, | ||
|
|
||
| setWindowState, |
Member
There was a problem hiding this comment.
Shall we hide this interface? I am thinking exposing this method may give too much details of the module.
Member
Author
There was a problem hiding this comment.
Nice comment. Do you think I can work this as a follow up? windowState is mainly UI related like paddingSize, open and mode. The current pattern is like direct expose, similar to other plugins.
// Core exposes setter
core.workspaces.setClient(client)
// Plugin uses it
this.coreStart.workspaces.setClient(myClient);
We can unify the pattern later in the follow-up?
Signed-off-by: Anan Zhuang <ananzh@amazon.com>
wanglam
approved these changes
Dec 3, 2025
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
src/plugins/chat/public/services/chat_service.ts (1)
279-283: !workspaces branch bypasses global default data source.The
!workspacesbranch (Lines 279-283) logs "using global scope" but returnsundefinedwithout callinggetDefaultDataSourceId. This means non-workspace deployments ignore any configured global default data source and always fall back to the local cluster, which is inconsistent with the workspace-enabled path (Lines 285-295).This issue was previously flagged in a past review comment.
Apply this diff to honor global defaults in non-workspace deployments:
const workspaces = this.workspaces; if (!workspaces) { // eslint-disable-next-line no-console console.warn('Workspaces service not available, using global scope'); - return undefined; + const dataSourceId = await getDefaultDataSourceId(this.uiSettings, UiSettingScope.GLOBAL); + return dataSourceId || undefined; }
🧹 Nitpick comments (5)
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (2)
9-9: Prefer using the sharedcoreChatServiceMockinstead of a hand-rolled mockYou’re manually mirroring the
ChatServiceStartsurface here; this will drift as the core chat API evolves and doesn’t provide realistic return values (e.g., observables fromgetThreadId$/getWindowState$). Consider switching to the central mock (e.g.,coreChatServiceMock.createStartContract()fromsrc/core/public/chat/chat_service.mock.ts) and then overriding only the behaviours this test cares about (isAvailable,isWindowOpen,sendMessageWithWindow, etc.). This will keep tests aligned with the core contract and reduce future maintenance.Also applies to: 26-47
171-195: Verify that log context is still included in the chat message flow and add/assert tests accordinglyThese tests now assert that
sendMessageWithWindowis called with the user question and an empty array ([]). Given this component is “Ask AI” for a log entry and the success message still says “with log context”, please double‑check that:
- The log context (document ID, index, message, etc.) is still being forwarded somewhere in the new architecture (e.g., via the plugin service or tools), and
- If so, that behaviour is covered by tests (either here or in a more appropriate layer), ideally by asserting the structured payload rather than just
[].If the context is intentionally no longer passed from this component, it might be worth updating the success copy and/or adding explicit tests at the new integration point to avoid a silent regression in log-aware AI responses.
Also applies to: 196-221, 248-267
src/plugins/chat/public/plugin.ts (2)
94-112: Consider deferring ChatService initialization when disabled.The comment states "core service handles enablement," but the code still creates a ChatService instance even when
!isEnabled(Line 106), only to returnundefinedin the start contract (Line 110). This creates an unused service instance and wastes resources.Consider either:
- Moving the ChatService instantiation inside the
isEnabledblock if it's truly disabled- Returning the chatService instance even when disabled if the core service should manage all enablement logic
The current approach is inconsistent with both patterns.
141-141: Non-null assertions are safe but fragile.The
this.chatService!assertions (Lines 141, 177) are safe because they're within theisEnabledblock where chatService is guaranteed to be defined. However, this pattern is fragile—if the control flow changes, runtime errors could occur.Consider storing chatService in a local variable after initialization to make the type narrowing explicit:
// Always initialize chat service - core service handles enablement this.chatService = new ChatService(core.uiSettings, core.chat, core.workspaces); if (!isEnabled) { return { chatService: undefined, }; } +const chatService = this.chatService; // Type is now narrowed to non-undefined // Register implementation functions with core chat service if (this.coreSetup?.chat?.setImplementation) { this.coreSetup.chat.setImplementation({ // Only business logic operations - sendMessage: this.chatService.sendMessage.bind(this.chatService), + sendMessage: chatService.sendMessage.bind(chatService), // ... etc }); }Also applies to: 177-177
src/plugins/chat/public/services/chat_service.ts (1)
74-86: Optional constructor parameter but required in methods.The constructor accepts
coreChatService?: ChatServiceStartas optional (Line 56), butgetThreadId()andgetThreadId$()throw if it's unavailable (Lines 75-77, 82-84). This creates a mismatch:
- If the service is optional at construction, methods should handle its absence gracefully
- If it's required for operation, consider making it a required constructor parameter
The current pattern will lead to runtime errors if ChatService is constructed without the core service but these methods are called.
Consider either:
- Making
coreChatServicerequired in the constructor- Returning a default value or throwing a more specific error during construction if it's missing
- Handling the undefined case gracefully in these methods (e.g., returning a default threadId or a BehaviorSubject with a default value)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
src/plugins/dashboard/public/application/components/dashboard_top_nav/__snapshots__/dashboard_top_nav.test.tsx.snapis excluded by!**/*.snap
📒 Files selected for processing (6)
src/core/public/chat/chat_service.test.ts(1 hunks)src/plugins/chat/opensearch_dashboards.json(1 hunks)src/plugins/chat/public/plugin.test.ts(5 hunks)src/plugins/chat/public/plugin.ts(5 hunks)src/plugins/chat/public/services/chat_service.ts(15 hunks)src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx(7 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- src/plugins/chat/opensearch_dashboards.json
- src/core/public/chat/chat_service.test.ts
🧰 Additional context used
🧬 Code graph analysis (4)
src/plugins/chat/public/plugin.test.ts (2)
src/plugins/chat/public/services/chat_service.ts (1)
ChatService(37-517)src/plugins/chat/public/plugin.ts (1)
ChatPlugin(41-192)
src/plugins/explore/public/components/ask_ai_action_item/ask_ai_action_item.test.tsx (3)
src/core/public/chat/types.ts (1)
ChatServiceStart(195-203)src/core/public/chat/index.ts (1)
ChatServiceStart(9-9)src/core/public/index.ts (1)
ChatServiceStart(440-440)
src/plugins/chat/public/plugin.ts (4)
src/core/public/index.ts (2)
CoreSetup(262-298)CoreStart(321-358)src/plugins/chat/public/types.ts (3)
ChatPluginSetup(12-14)AppPluginStartDependencies(20-24)ChatPluginStart(16-18)src/plugins/chat/public/services/chat_service.ts (1)
ChatService(37-517)src/core/public/chat/chat_service.ts (1)
ChatService(19-169)
src/plugins/chat/public/services/chat_service.ts (5)
src/core/public/index.ts (5)
IUiSettingsClient(399-399)ChatServiceStart(440-440)WorkspacesStart(421-421)Message(442-442)ChatWindowState(443-443)src/core/public/chat/types.ts (3)
ChatServiceStart(195-203)Message(82-87)ChatWindowState(97-101)src/core/public/chat/index.ts (3)
ChatServiceStart(9-9)Message(11-11)ChatWindowState(20-20)src/plugins/chat/public/services/ag_ui_agent.ts (1)
AgUiAgent(22-142)src/plugins/data_source_management/public/index.ts (1)
getDefaultDataSourceId(29-29)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (990)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run cypress tests (osd:ciGroup7)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup10Fast)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup9)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup10Slow)
- GitHub Check: Run cypress tests (osd:ciGroup1)
- GitHub Check: Run cypress tests (osd:ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup6)
- GitHub Check: Run cypress tests (osd:ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup2)
- GitHub Check: Run cypress tests (osd:ciGroup3)
- GitHub Check: Run cypress tests (osd:ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup1)
- GitHub Check: bundle-analyzer
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: lighthouse
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run functional tests on Linux (ciGroup7)
- GitHub Check: Run functional tests on Linux (ciGroup3)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup4)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup1)
- GitHub Check: Run functional tests on Linux (ciGroup2)
- GitHub Check: Run plugin functional tests on Windows
- GitHub Check: Build min release artifacts on Windows x64
- GitHub Check: Run plugin functional tests on Linux
- GitHub Check: Build min release artifacts on macOS ARM64
- GitHub Check: Build min release artifacts on macOS x64
- GitHub Check: Build min release artifacts on Linux ARM64
- GitHub Check: Build min release artifacts on Linux x64
- GitHub Check: Build and Verify on Windows (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup4)
- GitHub Check: Build and Verify on Windows (ciGroup1)
- GitHub Check: Build and Verify on Windows (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup2)
- GitHub Check: Build and Verify on Linux (ciGroup3)
- GitHub Check: Build and Verify on Linux (ciGroup1)
- GitHub Check: Lint and validate
- GitHub Check: Run cypress tests (osd:ciGroup14)
- GitHub Check: Run cypress tests (osd:ciGroup17Explore)
- GitHub Check: Run functional tests on Windows (ciGroup3)
- GitHub Check: Run functional tests on Windows (ciGroup11)
- GitHub Check: Run cypress tests (osd:ciGroup16Explore)
- GitHub Check: Run cypress tests (osd:ciGroup12Explore)
- GitHub Check: Run cypress tests (osd:ciGroup15)
- GitHub Check: Run functional tests on Linux (ciGroup5)
- GitHub Check: Run cypress tests (osd:ciGroup10Explore)
- GitHub Check: Run functional tests on Windows (ciGroup7)
- GitHub Check: Run functional tests on Windows (ciGroup4)
- GitHub Check: Run cypress tests (osd:ciGroup14Explore)
- GitHub Check: Run functional tests on Windows (ciGroup12)
- GitHub Check: Run functional tests on Linux (ciGroup8)
- GitHub Check: Run cypress tests (osd:ciGroup15Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13Explore)
- GitHub Check: Run cypress tests (osd:ciGroup13)
- GitHub Check: Run functional tests on Linux (ciGroup9)
- GitHub Check: Run functional tests on Windows (ciGroup5)
- GitHub Check: Run functional tests on Windows (ciGroup8)
- GitHub Check: Run functional tests on Windows (ciGroup9)
- GitHub Check: Run functional tests on Linux (ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup6)
- GitHub Check: Run functional tests on Windows (ciGroup10)
- GitHub Check: Run functional tests on Windows (ciGroup2)
- GitHub Check: Run functional tests on Windows (ciGroup13)
- GitHub Check: Run functional tests on Windows (ciGroup6)
- GitHub Check: Run functional tests on Linux (ciGroup13)
- GitHub Check: Run cypress tests (osd:ciGroup11)
- GitHub Check: Run functional tests on Linux (ciGroup10)
- GitHub Check: Run functional tests on Linux (ciGroup12)
- GitHub Check: Run cypress tests (osd:ciGroup12)
SuZhou-Joe
approved these changes
Dec 3, 2025
6 tasks
7 tasks
This was referenced Dec 23, 2025
7 tasks
This was referenced Jan 29, 2026
Merged
This was referenced Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the chat plugin architecture by extracting shared infrastructure into a core chat service. This establishes a clean separation of concerns where the core manages state infrastructure and plugins provide business logic through delegation.
Key Changes
Architecture Refactoring
Infrastructure vs Business Logic Separation
Issues Resolved
NA
Screenshot
refactor-chat.mov
refactor-investigation.mov
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integrationSummary by CodeRabbit
New Features
Refactor
Tests
✏️ Tip: You can customize this high-level summary in your review settings.