Skip to content

fix tool result messages not containing latest user question#10758

Closed
jiapingzeng wants to merge 3 commits intoopensearch-project:mainfrom
jiapingzeng:agui-chat-fix
Closed

fix tool result messages not containing latest user question#10758
jiapingzeng wants to merge 3 commits intoopensearch-project:mainfrom
jiapingzeng:agui-chat-fix

Conversation

@jiapingzeng
Copy link
Copy Markdown
Contributor

@jiapingzeng jiapingzeng commented Oct 20, 2025

Description

Add user message to tool result request

Issues Resolved

fixes #10756

Screenshot

image

Testing the changes

Verified from browser network tab that chat is sending correct messages.

Changelog

  • fix: [BUG][Chat] fix tool result messages not containing latest user question

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions
Copy link
Copy Markdown
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

Signed-off-by: Jiaping Zeng <jpz@amazon.com>
@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Oct 20, 2025
ananzh
ananzh previously approved these changes Oct 21, 2025
@ananzh ananzh added ai Changes related to AI chat, context provider and artifact bug Something isn't working v3.4.0 labels Oct 21, 2025
@github-actions github-actions bot removed the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label Oct 21, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.51%. Comparing base (b175397) to head (e19cffd).
⚠️ Report is 124 commits behind head on main.

Files with missing lines Patch % Lines
src/plugins/chat/public/components/chat_window.tsx 0.00% 4 Missing ⚠️
...plugins/chat/public/services/chat_event_handler.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10758      +/-   ##
==========================================
- Coverage   60.51%   60.51%   -0.01%     
==========================================
  Files        4485     4485              
  Lines      120190   120191       +1     
  Branches    19912    19911       -1     
==========================================
- Hits        72737    72731       -6     
- Misses      42410    42417       +7     
  Partials     5043     5043              
Flag Coverage Δ
Linux_1 26.58% <ø> (ø)
Linux_2 38.82% <ø> (ø)
Linux_3 ?
Linux_4 33.28% <ø> (ø)
Windows_1 26.59% <ø> (ø)
Windows_2 38.79% <ø> (ø)
Windows_3 39.09% <28.57%> (-0.01%) ⬇️
Windows_4 33.28% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ananzh
Copy link
Copy Markdown
Member

ananzh commented Dec 5, 2025

close it as it is included in #10983
thanks @jiapingzeng for the contribution 💚

@ananzh ananzh closed this Dec 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Changes related to AI chat, context provider and artifact bug Something isn't working first-time-contributor v3.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Original user message missing in tool result request

2 participants