feat(dotnet): export opentelemetry metrics - #398
Merged
Conversation
Hawxy
reviewed
Jul 29, 2024
Hawxy
reviewed
Jul 29, 2024
rhamzeh
marked this pull request as ready for review
July 30, 2024 13:08
Hawxy
reviewed
Jul 30, 2024
rhamzeh
force-pushed
the
feat/dotnet-telemetry-metrics
branch
2 times, most recently
from
July 30, 2024 18:55
0fcb161 to
cae5eb9
Compare
ewanharris
force-pushed
the
feat/dotnet-telemetry-metrics
branch
from
November 5, 2024 09:48
cae5eb9 to
fbbe656
Compare
ewanharris
force-pushed
the
feat/dotnet-telemetry-metrics
branch
2 times, most recently
from
November 15, 2024 12:27
fdf4bab to
fe65053
Compare
Note: These metrics have never been released in the .NET SDK
This makes it consistent with Proto naming
Considering that we already have histograms for them, and the const impact of having attributes with high variance, we're dropping the following two attributes: - `http.client.request.duration` - `http.server.request.duration`
ewanharris
force-pushed
the
feat/dotnet-telemetry-metrics
branch
from
November 18, 2024 21:36
fe65053 to
5347626
Compare
Member
Author
|
@evansims @jimmyjames I can't approve this PR, would either of you mind giving it a look? |
ewanharris
enabled auto-merge
November 25, 2024 16:06
jimmyjames
approved these changes
Nov 26, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds initial OpenTelemetry metrics to the .NET SDK
References
Generates: openfga/dotnet-sdk#69
Review Checklist
main