Upgrade ethereum types by ordian · Pull Request #10670 · openethereum/parity-ethereum

ordian · 2019-05-16T16:53:32Z

We've accumulated technical debt by not upgrading ethereum-types and other related dependencies.
This PR tries to fix that to take advantage of recent improvements introduced in the uint crate.

Unrelated changes:

fix some warnings
upgrade rand to 0.6

Figure out how to fix compilation of ethcore-blockchain
Fix compilation in tests
Publish new keccak-hash
Publish ethereum-types 0.6.0 ([ethereum-types] bump to 0.6 paritytech/parity-common#165)
Publish new ethabi (https://github.com/paritytech/ethabi/pull/151)
Publish ethbloom 0.6.4 with rlp encoding ([ethbloom] impl rlp for Bloom paritytech/parity-common#164)
replace git dependencies with published ones

* master: docs: Add ProgPoW Rust docs to ethash module (#10653) fix: Move PR template into .github/ folder (#10663) docs: Add PR template (#10654) Trivial journal for private transactions (#10056) fix(compilation warnings) (#10649) [whisper] Move needed aes_gcm crypto in-crate (#10647) Adds parity_getRawBlockByNumber, parity_submitRawBlock (#10609) Fix rinkeby petersburg fork (#10632) ci: publish docs debug (#10638)

@dvdplm

Thanks a lot @dvdplm :)

dvdplm · 2019-05-17T08:26:33Z

@@ -157,7 +157,12 @@ impl DatabaseDirectories {
 	/// Base DB directory for the given fork.
 	// TODO: remove in 1.7


This is an interesting comment. Still relevant?

ordian · 2019-05-29T11:37:18Z

+			0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+			0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xfe,
+			0xba, 0xae, 0xdc, 0xe6, 0xaf, 0x48, 0xa0, 0x3b,
+			0xbf, 0xd2, 0x5e, 0x8c, 0xd0, 0x36, 0x41, 0x41,


I've changed some bytes here to see if tests fail, but sadly, there were no test to catch that.

dvdplm

lgtm, minor nits

Co-Authored-By: David <dvdplm@gmail.com>

ordian · 2019-05-29T15:16:45Z

Putting on ice till ethabi 8.0.0 is published to avoid accidental merge.

* master: introduce MissingParent Error, fixes #10699 (#10700) Update publishing (#10644)

* master: Upgrade ethereum types (#10670)

…ypto-from-devp2p * dp/chore/devp2p-cosmetics: Reorg imports Upgrade ethereum types (#10670)

ordian added 19 commits May 8, 2019 16:26

cargo upgrade "ethereum-types" --all --allow-prerelease

69b36a7

[ethash] fix compilation errors

cad3e17

[ethkey] fix compilation errors

68916b9

[journaldb] fix compilation errors

3523b24

[dir] fix compilation errors

fdd6da4

[ethabi] update to 0.7

f889d7b

wip

2a28200

[eip-712] fix compilation errors

86f16f6

[ethjson] fix compilation errors

7583780

[Cargo.toml] add TODO to remove patches

fa9ef81

[ethstore] fix compilation errors

f8ce152

use patched keccak-hash with new primitive-types

c7b4527

wip

09c92c2

[ethcore-network-devp2p] fix compilation errors

ab906ca

[vm] fix compilation errors

c974f92

[common-types, evm, wasm] fix compilation errors

17e8e52

[ethcore-db] Require AsRef instead of Deref for keys

c188f13

[ethcore-blockchain] fix some compilation errors

1fca62e

ordian added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. M5-dependencies 🖇 Dependencies. labels May 16, 2019

ordian added 2 commits May 16, 2019 21:30

[blooms-db] fix compilation errors

8bfc263

Thanks a lot @dvdplm :)

we don't need no rlp ethereum feature

9bcb992

dvdplm reviewed May 17, 2019

View reviewed changes

ordian commented May 17, 2019

View reviewed changes

Comment thread accounts/ethstore/src/accounts_dir/memory.rs

dvdplm mentioned this pull request May 17, 2019

[rlp] Upgrade ethereum-types dependency paritytech/parity-common#158

Merged

ordian added 3 commits May 17, 2019 14:54

[ethcore] fix some compilation errors

4bb39c5

[parity-ipfs-api] fix compilation error

46e3b2d

[ethcore-light] fix compilation errors

dce478f

ordian added 6 commits May 29, 2019 11:44

[ethcore] remove resolved TODO

09cb8b7

[*] resolve keccak-hash TODO

73e4cae

[*] s/Address::default()/Address::zero()

7ed62da

[rpc] remove Subscribers::new_test

a9cca6e

[rpc] remove EthPubSubClient::new_test

d22a478

[ethcore] use trie-standardmap from crates.io

57787b8

ordian mentioned this pull request May 29, 2019

[ethcore-network-devp2p] get rid of rust-crypto dependency #10698

Closed

ordian added this to the 2.6 milestone May 29, 2019

[dir] fix db_root_path

b7a700d

ordian commented May 29, 2019

View reviewed changes

[ethcore] simplify snapshot::tests::helpers::fill_storage

8264f90

dvdplm approved these changes May 29, 2019

View reviewed changes

Comment thread Cargo.toml Outdated

Comment thread util/triehash-ethereum/Cargo.toml Outdated

Comment thread util/network-devp2p/src/host.rs Outdated

Comment thread util/network-devp2p/src/connection.rs

ordian and others added 4 commits May 29, 2019 16:46

Apply suggestions from code review

b349df9

Co-Authored-By: David <dvdplm@gmail.com>

[ethcore-secretstore] resolve TODO in serialization

016d682

[ethcore-network-devp2p] resolve TODO in save_key

4dbba7e

[Cargo.lock] update triehash

e479218

ordian added the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label May 29, 2019

ordian added 3 commits June 3, 2019 15:12

[*] use ethabi from crates.io

9181be7

[ethkey] use secp256k1 from master branch

722971b

Merge branch 'master' into ao-upgrade-ethereum-types

94db3a0

* master: introduce MissingParent Error, fixes #10699 (#10700) Update publishing (#10644)

ordian removed the A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. label Jun 3, 2019

[Cargo.lock] update eth-secp256k1

72d9b6e

dvdplm merged commit dae5d75 into master Jun 3, 2019

ordian deleted the ao-upgrade-ethereum-types branch June 3, 2019 13:36

dvdplm added a commit that referenced this pull request Jun 3, 2019

Merge branch 'master' into dp/chore/devp2p-cosmetics

d5d1eb0

* master: Upgrade ethereum types (#10670)

dvdplm added a commit that referenced this pull request Jun 3, 2019

Merge branch 'dp/chore/devp2p-cosmetics' into dp/chore/remove-rust-cr…

6f51390

…ypto-from-devp2p * dp/chore/devp2p-cosmetics: Reorg imports Upgrade ethereum types (#10670)

ordian mentioned this pull request Jun 17, 2019

updater: fix static id hashes initialization #10755

Merged

ordian mentioned this pull request Jan 11, 2021

Update uint package to v0.8 openethereum/openethereum#212

Closed

rakita mentioned this pull request Jan 25, 2021

Upgrade dependencies openethereum/openethereum#223

Open

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade ethereum types#10670

Upgrade ethereum types#10670
dvdplm merged 96 commits into
masterfrom
ao-upgrade-ethereum-types

ordian commented May 16, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvdplm May 17, 2019

Uh oh!

Uh oh!

Uh oh!

ordian May 29, 2019

Uh oh!

dvdplm left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ordian commented May 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -157,7 +157,12 @@ impl DatabaseDirectories {
		/// Base DB directory for the given fork.
		// TODO: remove in 1.7

Conversation

ordian commented May 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dvdplm May 17, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ordian May 29, 2019

Choose a reason for hiding this comment

Uh oh!

dvdplm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ordian commented May 29, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ordian commented May 16, 2019 •

edited

Loading