ci: publish docs debug#10638
Conversation
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
| echo "__________Upload files__________" | ||
| git push -q origin HEAD | ||
| git push -q -f --tags | ||
| # this version of git (2.7.4) will dump the token on failure |
There was a problem hiding this comment.
Why do we even use token instead of a deploy SSH key?
| git push -q -f --tags | ||
| # this version of git (2.7.4) will dump the token on failure | ||
| git push -q origin HEAD 2>&1 \ | ||
| | sed -r "s|(${GITHUB_USER}):[a-f0-9]+@|\1:REDACTED@|g" |
There was a problem hiding this comment.
I find it possible that git will change the failure format and this regexp will stop redacting the secret...
And this failure will be terribly hard to notice in advance...
There was a problem hiding this comment.
It's the most simple pattern username:token
kirushik
left a comment
kirushik
left a comment
There was a problem hiding this comment.
I don't mind this as a hotfix — but in later iterations I would prefer us redesigning system to follof the "fail closed" principle: like deployment-only SSH key which is only authorized to push in this particular repo, or even migrating to just using Github/Gitlab pages without resorting to manual pushes.
|
LGTM, also I'd vote moving to gitlab/github pages later |
|
thanks, I don't mind at all moving to something else when there is time to plan. |
|
labels! |
soc1c
added
A8-looksgood 🦄
* ci: publish docs debug (#10638) * ci: backport missing diff from master
* ci: publish docs debug (#10638) * ci: backport missing diff from master
* master: docs: Add ProgPoW Rust docs to ethash module (#10653) fix: Move PR template into .github/ folder (#10663) docs: Add PR template (#10654) Trivial journal for private transactions (#10056) fix(compilation warnings) (#10649) [whisper] Move needed aes_gcm crypto in-crate (#10647) Adds parity_getRawBlockByNumber, parity_submitRawBlock (#10609) Fix rinkeby petersburg fork (#10632) ci: publish docs debug (#10638)
5 participants
No description provided.