Skip to content

[ethbloom] impl rlp for Bloom#164

Merged
ordian merged 3 commits into
masterfrom
ao-rlp-for-ethbloom
May 23, 2019
Merged

[ethbloom] impl rlp for Bloom#164
ordian merged 3 commits into
masterfrom
ao-rlp-for-ethbloom

Conversation

@ordian
Copy link
Copy Markdown
Contributor

@ordian ordian commented May 23, 2019

cc #158

@ordian ordian requested a review from dvdplm May 23, 2019 09:34
dvdplm
dvdplm approved these changes May 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modulo the impl-rlp version: do you want to wait for #158 ?

Comment thread ethbloom/Cargo.toml Outdated
ordian and others added 2 commits May 23, 2019 14:26
@ordian ordian requested a review from ascjones May 23, 2019 12:51
@ordian ordian mentioned this pull request May 23, 2019
Merged
7 tasks
ascjones
ascjones approved these changes May 23, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ordian ordian merged commit 00da406 into master May 23, 2019
@ordian ordian deleted the ao-rlp-for-ethbloom branch May 23, 2019 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@ascjones ascjones ascjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ordian @dvdplm @ascjones