Skip to content

Fix alt text for the login page: LMS-600 - #382

Merged
mikigoyal merged 2 commits into
masterfrom
bug/lms-600
Jul 12, 2013
Merged

Fix alt text for the login page: LMS-600#382
mikigoyal merged 2 commits into
masterfrom
bug/lms-600

Conversation

@mikigoyal

Copy link
Copy Markdown

@sarina can you quickly look at this pull request?

Comment thread lms/templates/login.html

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the yelling. Prefer something like

Please log in or Please, Log In - unless there's a reason to make it all caps

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements said to match the text in the UI. :)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see. hrmph.

@sarina

sarina commented Jul 12, 2013

Copy link
Copy Markdown
Contributor

Add yourself to AUTHORS

@mikigoyal

Copy link
Copy Markdown
Author

Changes made to add myself to the AUTHORs file.

@sarina

sarina commented Jul 12, 2013

Copy link
Copy Markdown
Contributor

👍 , :shipit:

mikigoyal pushed a commit that referenced this pull request Jul 12, 2013
Fix alt text for the login page: LMS-600
@mikigoyal
mikigoyal merged commit 4eb8222 into master Jul 12, 2013
@mikigoyal
mikigoyal deleted the bug/lms-600 branch July 12, 2013 14:45
chrisrossi pushed a commit to jazkarta/edx-platform that referenced this pull request Mar 31, 2014
…control

Did a quick security scan through views.
e-kolpakov referenced this pull request in open-craft/openedx-platform Feb 6, 2015
mattdrayer/MCKIN-2725: Added support for course roles deletion
Yasui-ks added a commit to nttks/edx-platform that referenced this pull request Oct 2, 2015
diegomillan pushed a commit to eduNEXT/edx-platform that referenced this pull request Sep 14, 2016
* tabs/discussion:
  Allow hiding of discussion tab in CMS
Sujeet1379 pushed a commit to chandrudev/edx-platform that referenced this pull request Nov 17, 2022
* upgrade paragon

* mmp2p experiment code

* mmp2p courseware triggers

* mmp2p course-home triggers

* mmp2p load styles

* mmp2p - add missed locator docstrings

* mmp2p test fixes

* add lazy loading for image-bearing components

* mmp2p experiment README

* mmp2p add lazy loading for sidecard

* generalize prices for currency options

* mmp2p fix flyover mobile args

* mmp2p fix lock paywall border display

* mmp2 - add safety-rail around verifiedmode access
Danyal-Faheem pushed a commit to Danyal-Faheem/edx-platform that referenced this pull request Jul 15, 2025
Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: Ali-Salman29 <Ali-Salman29@users.noreply.github.com>
kiram15 pushed a commit that referenced this pull request Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants