Skip to content

Fix alt text for the login page: LMS-600 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikigoyal merged 2 commits into from
Jul 12, 2013
Merged

Fix alt text for the login page: LMS-600 #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd8446
Fix alt text for the login page: LMS-600
Jul 12, 2013
4c8eb6b
Adding myself to authors file
Jul 12, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,5 @@ Bethany LaPenta <lapentab@mit.edu>
Renzo Lucioni <renzolucioni@gmail.com>
Felix Sun <felixsun@mit.edu>
Adam Palay <adam@edx.org>
Ian Hoover <ihoover@edx.org>
Ian Hoover <ihoover@edx.org>
Mukul Goyal <miki@edx.org>
2 changes: 1 addition & 1 deletion lms/templates/login.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@

<section class="introduction">
<header>
<h1 class="sr">${_("Log Into Your Account")}</h1>
<h1 class="sr">${_("PLEASE LOG IN to access your account and courses")}</h1>

@sarina sarina Jul 12, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the yelling. Prefer something like

Please log in or Please, Log In - unless there's a reason to make it all caps

@mikigoyal mikigoyal Jul 12, 2013

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requirements said to match the text in the UI. :)

@sarina sarina Jul 12, 2013

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see. hrmph.

</header>
</section>

Expand Down