fix: discussion xss fix [BB-4600] - #382
Merged
Agrendalath merged 1 commit intoAug 4, 2021
Merged
Conversation
(cherry picked from commit 82939c3)
shimulch
approved these changes
Aug 4, 2021
shimulch
left a comment
shimulch
left a comment
There was a problem hiding this comment.
@Agrendalath LGTM 👍
- I tested this: run this on localhost, checked discussions ui, ensure things loading correctly
- I read through the code
- I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
Agrendalath
deleted the
agrendalath/bb-4600-backport_discussions_xss_fix
branch
August 4, 2021 13:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 82939c3)
This backports edx/edx-platform#28371 to our common Koa branch.
Testing instructions