feat: [FC-0044] Course unit - Edit iframe modal window

[peterkulko]

🚨 Dependencies:

• 🔗 Authoring MFE

Description

This PR adds logic to support the functionality of editing xblocks via the legacy modal editing window.

Useful information to include:

• Communication between the Backbone.js and the React app is done via post messages.
• xBlock resources (CSS, JS files) are passed to the legacy modal edit window template.
• Added some styles for xblock legacy modal content.

Supporting information

The next PR will be adding post messages for the tagging functionality.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
• If your database migration can't be rolled back easily.

[openedx-webhooks]

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

[arbrandes]

I don't love the fact we need so many CSS fixes in cms/static/sass/course-unit-mfe-iframe-bundle.scss, but I figure this is just part doing business with this code. (I suspect the existing XBlock editors are making bad assumptions about the surrounding styles to begin with.)

I also have no way to test the Hotjar stuff, so we'll just deal with it if issues arise down the line.

And finally, as before I'm not going to block this from merging, but I was able to get more details in the y-scrolling issue identified earlier. When you create a block for the first time and save it, the y position is not changed to find it after loading. This is not observed when you edit a block after it already exists, in which case the scroll happens correctly. If this is confirmed to be a regression, we should fix it in future PRs.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.

[peterkulko]

I don't love the fact we need so many CSS fixes in cms/static/sass/course-unit-mfe-iframe-bundle.scss, but I figure this is just part doing business with this code. (I suspect the existing XBlock editors are making bad assumptions about the surrounding styles to begin with.)

Yes, you are right. Since the styling of different xblocks can be implemented differently (most styles do not rely on Paragon), the course-unit-mfe-iframe-bundle.scss file was created to improve the UI/UX when working with modal editing windows.

And finally, as before I'm not going to block this from merging, but I was able to get more details in the y-scrolling issue identified openedx/frontend-app-authoring#1544 (review). When you create a block for the first time and save it, the y position is not changed to find it after loading. This is not observed when you edit a block after it already exists, in which case the scroll happens correctly. If this is confirmed to be a regression, we should fix it in future PRs.

Thanks, I remember about it, I will fix it in the next PR