feat: [FC-0070] Manage Tags interoperation by peterkulko · Pull Request #1454 · openedx/frontend-app-authoring

peterkulko · 2024-10-31T19:14:17Z

🚨 Dependencies:

🔗 edx-plarform PR

Description

Added interaction between MFE and Legacy tagging functionality for xblocks on the Course unit page.

Useful information to include:

fixed problem with scrolling after creating a new xblock with a new editor (feat: [FC-0044] Course unit - Edit iframe modal window openedx-platform#35777 (review))

Testing instructions

Screen.Recording.2025-02-24.at.15.35.58.mov

Other information

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/raccoongang/edx-platform.git
EDX_PLATFORM_VERSION: Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View

TUTOR_GROVE_NEW_MFES:
  authoring:
    port: 18000
    repository: https://github.com/raccoongang/frontend-app-course-authoring.git
    version: Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS:
  MFE_CONFIG:
    ENABLE_UNIT_PAGE: true

openedx-webhooks · 2024-10-31T19:14:21Z

Thanks for the pull request, @PKulkoRaccoonGang!

This repository is currently maintained by @openedx/2u-tnl.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2024-11-04T11:46:37Z

Codecov Report

Attention: Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.38%. Comparing base (7e4ecff) to head (27c4533).
Report is 96 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/hooks.jsx	92.59%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1454      +/-   ##
==========================================
+ Coverage   93.33%   93.38%   +0.04%     
==========================================
  Files        1108     1109       +1     
  Lines       22045    22145     +100     
  Branches     4674     4692      +18     
==========================================
+ Hits        20575    20679     +104     
+ Misses       1405     1401       -4     
  Partials       65       65

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

open-craft-grove · 2025-02-24T14:35:25Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

bradenmacdonald · 2025-02-24T18:21:08Z

+    if (queryKey[0] === 'taxonomies') {
+      return {
+        data: {
+          results: [],
+        },
+        isSuccess: true,
+      };
+    }


Generally instead of mocking react-query we prefer to mock the API requests using the mocks defined in content-tags-drawer/data/api.mocks.ts.

So you can just write something like this at the top of your test file:

frontend-app-authoring/src/content-tags-drawer/ContentTagsDrawer.test.jsx

Lines 25 to 28 in 8fe52d2

mockContentTaxonomyTagsData.applyMock();

mockTaxonomyListData.applyMock();

mockTaxonomyTagsData.applyMock();

mockContentData.applyMock();

If you do want/need to keep it this way though, you should at least replace the 'taxonomies' string with taxonomyQueryKeys.all from here.

I like the option with mocks from content-tags-drawer the most, but unfortunately I couldn't run the tests successfully. Probably the problem is related to this mock @tanstack/react-query

Added taxonomyQueryKeys.all instead of the taxonomies line

Yeah those mocks won't work if you mock out react-query entirely.

Added taxonomyQueryKeys.all instead of the taxonomies line

Do you mind if we stop here?

Yeah that's fine. No need to rewrite it, but in the future be aware of the existing mocks we have (as well as everything in testUtils.tsx as they make writing new tests way simpler.

Thanks a lot!

open-craft-grove · 2025-02-25T13:18:49Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2025-02-25T14:35:17Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

arbrandes

This works well, and the code looks good. Approved!

arbrandes · 2025-03-03T14:06:54Z

Oh, and thank a bunch for fixing the scrolling issue!

* test: Remove support for Node 18 * chore: update code coverage artifact naming

peterkulko requested a review from a team as a code owner October 31, 2024 19:14

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 31, 2024

peterkulko marked this pull request as draft October 31, 2024 19:14

peterkulko self-assigned this Oct 31, 2024

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Nov 6, 2024

feat: manage tags for new Unit page

487d38f

peterkulko force-pushed the Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View branch from 3e33967 to 487d38f Compare February 23, 2025 23:34

peterkulko added 2 commits February 24, 2025 09:20

refactor: code refactoring

ca6cf11

refactor: added some test

09ced10

peterkulko force-pushed the Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View branch 3 times, most recently from 8bf4836 to b87a550 Compare February 24, 2025 11:51

refactor: code refactoring

62af3bd

peterkulko force-pushed the Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View branch from b87a550 to 62af3bd Compare February 24, 2025 13:20

peterkulko marked this pull request as ready for review February 24, 2025 13:32

peterkulko added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 24, 2025

peterkulko requested review from arbrandes, bradenmacdonald and ihor-romaniuk February 24, 2025 13:43

peterkulko mentioned this pull request Feb 24, 2025

feat: [FC-0070] Manage Tags interoperation openedx/openedx-platform#35751

Merged

bradenmacdonald reviewed Feb 24, 2025

View reviewed changes

peterkulko force-pushed the Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View branch from 6944a90 to b112c32 Compare February 25, 2025 12:59

refactor: code refactoring

27c4533

peterkulko force-pushed the Peter_Kulko/manage-tags-interoperation-between-mfe-and-Studio-xBlock-View branch from b112c32 to 27c4533 Compare February 25, 2025 13:16

peterkulko requested a review from bradenmacdonald February 26, 2025 11:45

arbrandes approved these changes Mar 3, 2025

View reviewed changes

arbrandes merged commit 411607e into openedx:master Mar 3, 2025

github-project-automation Bot moved this from Waiting on Author to Done in Contributions Mar 3, 2025

peterkulko added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Apr 24, 2025

Arpit-Nakrani-Networked pushed a commit to Arpit-Nakrani-Networked/frontend-app-authoring that referenced this pull request Jul 13, 2025

test: Remove support for Node 18 (openedx#1454)

6534347

* test: Remove support for Node 18 * chore: update code coverage artifact naming

	mockContentTaxonomyTagsData.applyMock();
	mockTaxonomyListData.applyMock();
	mockTaxonomyTagsData.applyMock();
	mockContentData.applyMock();

Uh oh!

Conversation

peterkulko commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Other information

Uh oh!

openedx-webhooks commented Oct 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

open-craft-grove commented Feb 24, 2025

Uh oh!

bradenmacdonald Feb 24, 2025

Choose a reason for hiding this comment

Uh oh!

peterkulko Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

peterkulko Feb 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bradenmacdonald Feb 26, 2025

Choose a reason for hiding this comment

Uh oh!

peterkulko Feb 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

open-craft-grove commented Feb 25, 2025

Uh oh!

open-craft-grove commented Feb 25, 2025

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

arbrandes commented Mar 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

peterkulko commented Oct 31, 2024 •

edited

Loading

openedx-webhooks commented Oct 31, 2024 •

edited

Loading

codecov Bot commented Nov 4, 2024 •

edited

Loading

peterkulko Feb 26, 2025 •

edited

Loading