feat: [FC-0044] expose editor for advanced xblocks and move modal in CMS - #34929
feat: [FC-0044] expose editor for advanced xblocks and move modal in CMS#34929GlugovGrGlib wants to merge 3 commits into
Conversation
* feat: expose editor for advanced xblocks * feat: added logic for displaying and hiding the xblock modal editing window * refactor: container_editor template refactoring --------- Co-authored-by: PKulkoRaccoonGang <peter.kulko@raccoongang.com> Co-authored-by: Іван Нєдєльніцев <ivan.niedielnitsev@raccoongang.com>
feat: finalize scripting for move and edit modals
refactor: after review
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @GlugovGrGlib! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Leaving this as a draft for reference, though the FC-0044 project is closed. |
|
Closed, implemented in #35777 |
4 participants
Description
In this PR a new view is added to CMS to render xblock modal views such as editor for advanced problem types and move xBlock modal. It's intended to use this view to render mentioned earlier interfaces in the course-authoring MFE. The course-authoring implementation can be found in this PR - openedx/frontend-app-authoring#985.
This particular decision was made because the functionality to edit and move modals depends on the BackboneJS implementation, and can't be recreated in the React.js within the current solution.
According to discussions in #34161 (comment) and openedx/frontend-app-authoring#964 (review) the final decision for rendering xblock previews will also affect rendering of the edit modal for advanced xBlock. Therefore, it was decided to postpone the merge of the current implementation, and revise it after the decision for xBlocks previews is made.
Supporting information
Issue: openedx/platform-roadmap#321
Testing instructions
Start CMS service
Copy xBlock locator for advanced problem
Open to - {CMS_BASE}/xblock/{xblock_locator}/actions/edit
See edit modal for the xBlock
Start CMS service
Copy xBlock locator for advanced problem
Open to - {CMS_BASE}/xblock/{xblock_locator}/actions/move
See move modal for the xBlock
Deadline
"None"
Other information
This PR is a replacement for the github.com//pull/34656