feat: [FC-0044] Course unit - Edit/move modals for xblocks by peterkulko · Pull Request #985 · openedx/frontend-app-authoring

peterkulko · 2024-05-07T11:47:42Z

Settings

EDX_PLATFORM_REPOSITORY: https://github.com/raccoongang/edx-platform.git
EDX_PLATFORM_VERSION: ts-develop

TUTOR_GROVE_WAFFLE_FLAGS:
  - name: contentstore.new_studio_mfe.use_new_unit_page
    everyone: true

TUTOR_GROVE_MFE_LMS_COMMON_SETTINGS:
  MFE_CONFIG:
    ENABLE_UNIT_PAGE: true

Description

Modal windows for moving and editing xblocks.

Supporting information

Issue: New Unit Page (Studio MFE conversion) platform-roadmap#321

Testing instructions

Run master devstack.
Start platform make dev.up.lms+cms+frontend-app-course-authoring and make checkout on this branch.
Enable the new Unit page by adding a waffle flag contentstore.new_studio_mfe.use_new_unit_page in the CMS admin panel.
Go to the Course Unit page from the Course Outline page.
Add a new xblock component.

Other information

Screen.Recording.2024-05-07.at.18.44.13.mov

openedx-webhooks · 2024-05-07T11:47:47Z

Thanks for the pull request, @PKulkoRaccoonGang!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/2u-tnl. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

codecov · 2024-05-07T14:24:41Z

Codecov Report

Attention: Patch coverage is 98.94737% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.27%. Comparing base (5c1df3e) to head (169a94a).
Report is 862 commits behind head on master.

Files with missing lines	Patch %	Lines
src/course-unit/hooks.jsx	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   92.24%   92.27%   +0.02%     
==========================================
  Files         704      707       +3     
  Lines       12444    12530      +86     
  Branches     2709     2726      +17     
==========================================
+ Hits        11479    11562      +83     
- Misses        929      932       +3     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

peterkulko · 2024-05-07T15:49:32Z

Waiting for the associated BE PR to be merged into the edx-platform

open-craft-grove · 2024-05-07T16:39:17Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-05-07T17:49:54Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

* feat: [AXIMST-28] added edit modals for xblocks * refactor: added postMessages * refactor: modals refactoring * refactor: code refactoring * refactor: after rebase * refactor: styles refactoring * refactor: code refactoring * refactor: create iframe component * refactor: error handling * fix: fixed tests * refactor: removed error handling * refactor: refactoring after review feat: added move modal and tests feat: added alert for successful unit movement feat: added alert logic refactor: code refactoring refactor: some refactoring refactor: code refactoring refactor: code refactoring refactor: refactoring after review refactor: after second review refactor: after rebase refactor: code refactoring refactor: tests refactoring

* fix: [AXIMST-769] added display of error alert * refactor: fixed tests

open-craft-grove · 2024-05-09T09:22:40Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-05-09T09:56:31Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

mariajgrimaldi · 2024-06-06T02:04:44Z

@arbrandes @brian-smith-tcril: could you give us a hand here? This would solve #1012. Thanks!

Also, @PKulkoRaccoonGang: could you resolve the branch conflicts? Thanks!

open-craft-grove · 2024-06-06T05:05:34Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-07T09:08:18Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-07T09:56:08Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

open-craft-grove · 2024-06-07T16:05:18Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

mphilbrick211 · 2024-07-17T17:10:29Z

@arbrandes @brian-smith-tcril: could you give us a hand here? This would solve #1012. Thanks!

Also, @PKulkoRaccoonGang: could you resolve the branch conflicts? Thanks!

@PKulkoRaccoonGang @arbrandes @brian-smith-tcril - hey all, just checking in on this!

open-craft-grove · 2024-07-17T17:45:36Z

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

peterkulko · 2024-07-22T08:03:28Z

@mariajgrimaldi @mphilbrick211 Hi! Thanks for paying attention to this PR. As far as I understand, the solution this PR provides will be discussed. This PR is currently on pause.

mphilbrick211 · 2024-07-25T18:17:08Z

[Inform] This PR will remain open as a draft for reference until the community decides the best way to tackle the problem

open-craft-grove · 2024-08-12T04:56:39Z

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

peterkulko · 2025-02-21T12:20:02Z

Closed, implemented in #1445

peterkulko requested a review from a team as a code owner May 7, 2024 11:47

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 7, 2024

peterkulko marked this pull request as draft May 7, 2024 11:47

peterkulko changed the title ~~feat: [AXIMST-28] added edit modals for xblocks (#223)~~ feat: Course unit - Edit/move modals for xblocks May 7, 2024

peterkulko force-pushed the Peter_Kulko/edit-and-move-modals branch 4 times, most recently from 25768dd to eeadefe Compare May 7, 2024 15:25

peterkulko self-assigned this May 7, 2024

peterkulko added the create-sandbox open-craft-grove should create a sandbox environment from this PR label May 7, 2024

peterkulko marked this pull request as ready for review May 7, 2024 15:40

peterkulko marked this pull request as draft May 7, 2024 15:47

peterkulko force-pushed the Peter_Kulko/edit-and-move-modals branch 2 times, most recently from d10c912 to 2c4a8d4 Compare May 7, 2024 15:59

peterkulko force-pushed the Peter_Kulko/edit-and-move-modals branch from 2c4a8d4 to ec0ae6b Compare May 9, 2024 08:42

fix: [AXIMST-769] Course unit - Added display of error alert (#233)

169a94a

* fix: [AXIMST-769] added display of error alert * refactor: fixed tests

peterkulko changed the title ~~feat: Course unit - Edit/move modals for xblocks~~ feat: [FC-0044] Course unit - Edit/move modals for xblocks May 9, 2024

peterkulko marked this pull request as ready for review May 9, 2024 12:33

peterkulko requested review from KristinAoki and arbrandes May 9, 2024 12:34

This was referenced Jun 6, 2024

feat: [FC-0044] expose editor for advanced xblocks and move modal in CMS openedx/openedx-platform#34929

Closed

New Unit Page (Studio MFE conversion) openedx/platform-roadmap#321

Closed

arbrandes marked this pull request as draft July 25, 2024 18:15

mphilbrick211 added the FC Relates to an Axim Funded Contribution project label Jul 30, 2024

peterkulko closed this Feb 21, 2025

Uh oh!

Conversation

peterkulko commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Settings

Description

Supporting information

Testing instructions

Other information

Uh oh!

openedx-webhooks commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's next?

🔘 Get product approval

🔘 Provide context

🔘 Get a green build

🔘 Update the status of your PR

🔘 Let us know that your PR is ready for review:

Who will review my changes?

Where can I find more information?

When can I expect my changes to be merged?

Uh oh!

codecov Bot commented May 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

peterkulko commented May 7, 2024

Uh oh!

open-craft-grove commented May 7, 2024

Uh oh!

open-craft-grove commented May 7, 2024

Uh oh!

open-craft-grove commented May 9, 2024

Uh oh!

open-craft-grove commented May 9, 2024

Uh oh!

mariajgrimaldi commented Jun 6, 2024

Uh oh!

open-craft-grove commented Jun 6, 2024

Uh oh!

open-craft-grove commented Jun 7, 2024

Uh oh!

open-craft-grove commented Jun 7, 2024

Uh oh!

open-craft-grove commented Jun 7, 2024

Uh oh!

mphilbrick211 commented Jul 17, 2024

Uh oh!

open-craft-grove commented Jul 17, 2024

Uh oh!

peterkulko commented Jul 22, 2024

Uh oh!

mphilbrick211 commented Jul 25, 2024

Uh oh!

open-craft-grove commented Aug 12, 2024

Uh oh!

peterkulko commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

peterkulko commented May 7, 2024 •

edited

Loading

openedx-webhooks commented May 7, 2024 •

edited

Loading

codecov Bot commented May 7, 2024 •

edited

Loading