feat: use profile name in navbar if available - #34493
Conversation
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d496d5d to
53c47bb
Compare
53c47bb to
ff326d9
Compare
ff326d9 to
a3ca801
Compare
a3ca801 to
1d0f0b9
Compare
1d0f0b9 to
b3253d2
Compare
|
@navinkarkera are you still hoping to merge this in? Is there an associated product proposal? |
Makes use of name field from user profile field if it is not empty
b3253d2 to
4afa49e
Compare
|
@sarina We don't have a product proposal for this one. But I still think it would be good to get this merged in. Once openedx/frontend-component-header#483 is approved, we can also go ahead here. |
|
This is a pretty visible change to the platform so I'm not comfortable merging it without Product approval. |
|
@sarina Ok, I'll check with the team and come back. |
|
@sarina I understand, thank you for letting us know. I think, we can safely drop these PRs and reimplement it for the client via slots. Kudos! |
Description
Makes use of name field from user profile field if it is not empty
Useful information to include:
Supporting information
Private-ref: BB-8772Testing instructions
Namefield via account settings.