Skip to content

feat: display profile name in navbar if available - #313

Closed
navinkarkera wants to merge 1 commit into
openedx:masterfrom
open-craft:navin/update-navbar-user
Closed

feat: display profile name in navbar if available#313
navinkarkera wants to merge 1 commit into
openedx:masterfrom
open-craft:navin/update-navbar-user

Conversation

@navinkarkera

Copy link
Copy Markdown

Display profile name if set, else fallback to username

Display profile name if set, else fallback to username
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 9, 2024
@openedx-webhooks

openedx-webhooks commented Apr 9, 2024

Copy link
Copy Markdown

Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@navinkarkera
navinkarkera marked this pull request as ready for review April 9, 2024 14:43
@navinkarkera
navinkarkera requested a review from a team as a code owner April 9, 2024 14:43
@itsjeyd itsjeyd added core contributor PR author is a Core Contributor (who may or may not have write access to this repo). waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 12, 2024
@jsnwesson

Copy link
Copy Markdown
Member

Hey all! I'm responding for the Aperture team. Any chance this would need a product review, or could you add context for where this change is being requested? Thanks!

@hurtstotouchfire

Copy link
Copy Markdown

Once https://github.com/openedx/frontend-component-header/pull/466/files merges, we will replace this custom header in learner dash with the standard component header, and then I think openedx/frontend-component-header#483 would provide this functionality, so likely this OSPR can just be closed.

That said, we should incorporate this into the product convo around removing username from the header. I think we'd need to pick between this approach and openedx/frontend-component-header#465 which puts username behind a flag.

FYI @arbrandes / @jmakowski1123

@itsjeyd itsjeyd added product review PR requires product review before merging and removed waiting for eng review PR is ready for review. Review and merge it, or suggest changes. labels Apr 22, 2024
@itsjeyd

itsjeyd commented Apr 22, 2024

Copy link
Copy Markdown

Hey @hurtstotouchfire, thanks for weighing in here.

That said, we should incorporate this into the product convo around removing username from the header.

Where is that conversation happening? Specifically, is there a product proposal that we could link this PR back to?

CC @jmakowski1123 @arbrandes @jsnwesson @navinkarkera

@arbrandes

Copy link
Copy Markdown
Contributor

@itsjeyd, I think the proposal is this one:

https://openedx.atlassian.net/wiki/spaces/OEPM/pages/4060938253/Proposal+Autogenerate+username+behind+a+flag

@hurtstotouchfire, shall we close this PR, then?

@jsnwesson

Copy link
Copy Markdown
Member

I'll go ahead and close this PR as there's already a PR #327 to replace the header with the frontend-component-header, which will allow us to customize the navbar in that library with this PR.

@jsnwesson jsnwesson closed this May 10, 2024
@openedx-webhooks

Copy link
Copy Markdown

@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

@itsjeyd itsjeyd added the duplicate This issue or pull request already exists elsewhere label May 23, 2024
@xitij2000
xitij2000 deleted the navin/update-navbar-user branch August 14, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). duplicate This issue or pull request already exists elsewhere open-source-contribution PR author is not from Axim or 2U product review PR requires product review before merging

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants