feat: display profile name in navbar if available - #313
Conversation
Display profile name if set, else fallback to username
|
Thanks for the pull request, @navinkarkera! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
Hey all! I'm responding for the Aperture team. Any chance this would need a product review, or could you add context for where this change is being requested? Thanks! |
|
Once https://github.com/openedx/frontend-component-header/pull/466/files merges, we will replace this custom header in learner dash with the standard component header, and then I think openedx/frontend-component-header#483 would provide this functionality, so likely this OSPR can just be closed. That said, we should incorporate this into the product convo around removing username from the header. I think we'd need to pick between this approach and openedx/frontend-component-header#465 which puts username behind a flag. FYI @arbrandes / @jmakowski1123 |
|
Hey @hurtstotouchfire, thanks for weighing in here.
Where is that conversation happening? Specifically, is there a product proposal that we could link this PR back to? |
|
@itsjeyd, I think the proposal is this one: @hurtstotouchfire, shall we close this PR, then? |
|
I'll go ahead and close this PR as there's already a PR #327 to replace the header with the |
|
@navinkarkera Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
Display profile name if set, else fallback to username