feat: use profile name in navbar if available - #651
Merged
navinkarkera merged 1 commit intoApr 12, 2024
Conversation
Makes use of name field from user profile field if it is not empty (cherry picked from commit 53c47bb095b4d885408d1f13589d23673230e520)
navinkarkera
force-pushed
the
navin/update-user-navbar-quince
branch
from
April 9, 2024 13:05
1b8a1c1 to
8ad8454
Compare
CefBoud
approved these changes
Apr 10, 2024
CefBoud
left a comment
CefBoud
left a comment
There was a problem hiding this comment.
Good job on this, @navinkarkera !
LGTM ✅
- I tested this
- I read through the code
- Includes documentation (N/A)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes use of name field from user profile field if it is not empty
Cherry pick of PR: openedx#34493