[BD-14] feat: implement V2 libraries usage for library content block - #30615
Conversation
|
Thanks for the pull request, @dyudyunov! When this pull request is ready, tag your edX technical lead. |
openedx-webhooks
added
the
blended
ad22fc3 to
cce72f9
Compare
|
Those failing tests are not related to the changes in my PR and they are floating - I've got them failed around 50% of the times I tried to run them locally |
cce72f9 to
e534499
Compare
|
@dyudyunov When do you anticipate this will be ready for a review? |
|
hi @natabene |
c68bda2 to
2647def
Compare
YT: https://youtrack.raccoongang.com/issue/EDX_BLND_CLI-87 - V2 libraries are available for selection in the Random Block edit modal; - selected V2 library blocks are copied to the modulestore and saved as children of the Random Block; - V2 library version validation works the same as for the V1 libraries (with possibility to update block with the latest version); - filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types; - the problem type field is hidden for v2 libraries in the edit mode; - unit tests added/updated.
2647def to
bd00331
Compare
dyudyunov
changed the title
|
@natabene now it's ready for the review 🎉 |
| Covers getting results for either library key as a string or LibraryLocatorV2. | ||
|
|
||
| NOTE: | ||
| We don't publish library updates so the library version will always be 0. |
There was a problem hiding this comment.
We don't publish library updates so the library version will always be 0.
Is this going to change, or are libraries going to remain unversioned?
There was a problem hiding this comment.
Libraries versioning works, but this isn't checked because the test goal here is to prove that the version could be received either for the id as a string or as a LibraryLocatorV2.
Publishing a library is a part of the content libraries functionality, not the library-content/library-sourced xblock so I don't test it here.
There was a problem hiding this comment.
Ah ok, this language is not wholly correct then. I knew libraries were versioned, I didn't know about the xblock level. Maybe We are not testing the library version here, so it will be 0 is more informative and less confusing.
There was a problem hiding this comment.
Ok
@connorhaugh don't you mind if I ask @UvgenGen to update this in his future PRs? I propose that because his work is based on this branch and I don't want him for rebasing several feature branches because of comment change )
|
How long do we plan to use both V1 and V2 libraries? |
I have no info about that 🙂 |
|
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
|
EdX Release Notice: This PR has been deployed to the production environment. |
5 participants
This will close Milestone 4.0b
Note: I didn’t add any additional permission checks for getting libraries, only reused current functionality (as we’ve discussed earlier). If the permission checks need any updates - it will be done as a separate task (to avoid blocking several tasks dependent on this one)