[BD-14] feat: implement V2 libraries usage for library content block - #30895
Closed
dyudyunov wants to merge 2 commits into
Closed
[BD-14] feat: implement V2 libraries usage for library content block#30895dyudyunov wants to merge 2 commits into
dyudyunov wants to merge 2 commits into
Conversation
YT: https://youtrack.raccoongang.com/issue/EDX_BLND_CLI-87 - V2 libraries are available for selection in the Random Block edit modal; - selected V2 library blocks are copied to the modulestore and saved as children of the Random Block; - V2 library version validation works the same as for the V1 libraries (with possibility to update block with the latest version); - filtering by problem type can't be done for V2 the same as for V1 because the v2 library problems are not divided by types; - the problem type field is hidden for v2 libraries in the edit mode; - unit tests added/updated.
openedx-webhooks
added
the
blended
|
Thanks for the pull request, @dyudyunov! When this pull request is ready, tag your edX technical lead. |
dyudyunov
changed the title
There could be a lot of bundles, so we can't use query params because it will raise the "Request-URI Too Long" error. Use the request data in such case.
dyudyunov
force-pushed
the
update-library-content-block-to-use-v2-libs
branch
from
August 26, 2022 15:00
fc0f248 to
c941170
Compare
dyudyunov
changed the title
|
@dyudyunov looks like this needs branch conflicts resolved before merging. Hi @connorhaugh - flagging for you as author is requesting an update. |
Contributor
Author
|
BD-14 project was closed in the RG and all additional work should be scheduled with our PMs |
4 tasks
Member
|
Closing in favor of #33263 |
|
@dyudyunov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
1 similar comment
|
@dyudyunov Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT!
This PR requires the openedx-unsupported/blockstore#197 to be merged first.
This PR consists of:
This will close Milestone 4.0b
Note: I didn’t add any additional permission checks for getting libraries, only reused current functionality (as we’ve discussed earlier). If the permission checks need any updates - it will be done as a separate task (to avoid blocking several tasks dependent on this one)