Revert "[BD-14] feat: implement V2 libraries usage for library content block" - #30872
Merged
rayzhou-bit merged 1 commit intoAug 17, 2022
Merged
Conversation
rayzhou-bit
self-requested a review
August 17, 2022 18:22
rayzhou-bit
approved these changes
Aug 17, 2022
rayzhou-bit
deleted the
revert-30615-update-library-content-block-to-use-v2-libs
branch
August 17, 2022 18:43
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Member
|
@connorhaugh do you have any details on what went wrong here? |
Contributor
Author
|
Hi, we no longer keep slack messages for long enough for me to look into why exactly we reverted this, but I belive it was because it broke v1 randomized content xblocks. I've made an updated version of this and several other changes here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #30615
due to reports of CL being broken.