Skip to content

Re-enable verify student identity acceptance tests - #1184

Merged
ormsbee merged 1 commit into
masterfrom
ormsbee/vcerts_accept_tests_cleanup
Oct 3, 2013
Merged

Re-enable verify student identity acceptance tests#1184
ormsbee merged 1 commit into
masterfrom
ormsbee/vcerts_accept_tests_cleanup

Conversation

@ormsbee

@ormsbee ormsbee commented Oct 1, 2013

Copy link
Copy Markdown
Contributor

AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING flag now toggles whether we really make any remote calls to Software Secure. @jzoldak @dianakhuang

This is just a patch for acceptance tests to and dev envs to run, does not include mocking + additional tests for verify student workflow.

Comment thread lms/djangoapps/verify_student/models.py Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're not just using this for the acceptance tests, I think we need a more descriptive comment here.

@dianakhuang

Copy link
Copy Markdown
Contributor

Other than those comments, this seems good. 👍

@ormsbee

ormsbee commented Oct 1, 2013

Copy link
Copy Markdown
Contributor Author

@jzoldak: look ok to you?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments can be removed now.

@jzoldak

jzoldak commented Oct 2, 2013

Copy link
Copy Markdown
Contributor

looks good.
👍 after making those few changes to comments in the .feature file.

…ance tests can run through certificate identity verification flow.
ormsbee pushed a commit that referenced this pull request Oct 3, 2013
Re-enable verify student identity acceptance tests
@ormsbee
ormsbee merged commit cd7d75a into master Oct 3, 2013
@ormsbee
ormsbee deleted the ormsbee/vcerts_accept_tests_cleanup branch October 3, 2013 13:08
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 23, 2016
…e_request_of_words_by_marketing_div

Change request of few messages by marketing div openedx#1184
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 30, 2016
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 30, 2016
…ording_of_the_japanese_for_profile

Fixed wording of the japanese for user profile openedx#1184
iloveagent57 pushed a commit that referenced this pull request Feb 26, 2024
As maintainers, we've been missing some issues that have been filed against
the repo. Hopefully this will fix that.

Ticket: edx/edx-arch-experiments#368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants