Skip to content

[TSD] add annotations for AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING feature flag - #26704

Merged
pdpinch merged 1 commit into
openedx:masterfrom
jramnai:tsd-automatic_verify_student_indentity_for_testing
Feb 25, 2021
Merged

[TSD] add annotations for AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING feature flag#26704
pdpinch merged 1 commit into
openedx:masterfrom
jramnai:tsd-automatic_verify_student_indentity_for_testing

Conversation

@jramnai

@jramnai jramnai commented Feb 24, 2021

Copy link
Copy Markdown
Contributor

Description

This PR adds annotations for AUTOMATIC_VERIFY_STUDENT_IDENTITY_FOR_TESTING feature flag.

Supporting information

https://github.com/edx/edx-platform/pull/1184

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @jramnai! I've created OSPR-5638 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 24, 2021
@edx-status-bot

Copy link
Copy Markdown

Your PR has finished running tests. There were no failures.

@jramnai

jramnai commented Feb 24, 2021

Copy link
Copy Markdown
Contributor Author

@natabene, this is ready for review.

@natabene

Copy link
Copy Markdown
Contributor

@jramnai Thank you for your contribution. @eLRuLL @BbrSofiane Could either of you please review this?

@eLRuLL

eLRuLL commented Feb 25, 2021

Copy link
Copy Markdown
Contributor

LGTM 👍 this should be ready to merge @edx/doc-a-thon-reviewers

@pdpinch
pdpinch merged commit 602efa5 into openedx:master Feb 25, 2021
@openedx-webhooks

Copy link
Copy Markdown

@jramnai 🎉 Your pull request was merged!

Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot

Copy link
Copy Markdown
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

@jramnai
jramnai deleted the tsd-automatic_verify_student_indentity_for_testing branch February 26, 2021 04:33
@natabene

Copy link
Copy Markdown
Contributor

@eLRuLL @pdpinch Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants