Skip to content

Add module grade to problem_check tracking log event - #1245

Merged
rocha merged 1 commit into
openedx:masterfrom
rocha:add-grade-to-problem-check-event
Oct 8, 2013
Merged

Add module grade to problem_check tracking log event#1245
rocha merged 1 commit into
openedx:masterfrom
rocha:add-grade-to-problem-check-event

Conversation

@rocha

@rocha rocha commented Oct 7, 2013

Copy link
Copy Markdown
Contributor

AN-160 #review

@rocha

rocha commented Oct 7, 2013

Copy link
Copy Markdown
Contributor Author

@mulby @ormsbee please review.

@ormsbee

ormsbee commented Oct 7, 2013

Copy link
Copy Markdown
Contributor

👍

@mulby

mulby commented Oct 8, 2013

Copy link
Copy Markdown
Contributor

LGTM 👍

@ichuang

ichuang commented Oct 8, 2013

Copy link
Copy Markdown
Contributor

isn't get_score already called once in this function, eg in self.publish_grade()?

@rocha

rocha commented Oct 8, 2013

Copy link
Copy Markdown
Contributor Author

@ichuang you are right, thanks for calling it out. I changed the code to prevent calling it twice.

Originally I expected that get_score have no side effects.

@mulby @ormsbee another quick look?

@mulby

mulby commented Oct 8, 2013

Copy link
Copy Markdown
Contributor

Still LGTM 👍

@ormsbee

ormsbee commented Oct 8, 2013

Copy link
Copy Markdown
Contributor

👍

rocha added a commit that referenced this pull request Oct 8, 2013
Add module grade to problem_check tracking log event
@rocha
rocha merged commit 779ff4f into openedx:master Oct 8, 2013
@rocha
rocha deleted the add-grade-to-problem-check-event branch October 8, 2013 21:00
jenkins-ks pushed a commit to nttks/edx-platform that referenced this pull request Sep 30, 2016
…ording_of_the_japanese_for_profile

Fixed wording of the japanese for user profile openedx#1184
lgp171188 pushed a commit to open-craft/openedx-platform that referenced this pull request Nov 30, 2018
MCKIN-8666: bump xblock problem builder version to 2.11.1
iloveagent57 pushed a commit that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants