chore: show unsupported error screen for gated content #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@saeedbashir please look on tests |
rnr
reviewed
Jul 24, 2024
| @@ -9,33 +9,37 @@ import SwiftUI | |||
| import Core | |||
| import Theme | |||
|
|
|||
| struct UnknownView: View { | |||
| public struct UnknownView: View { | |||
There was a problem hiding this comment.
maybe better name is 'NotAvailableOnMobileView' or something like that?
| .padding(.top, 12) | ||
| StyledButton(CourseLocalization.NotAvaliable.button, action: { | ||
| if let url = URL(string: url) { | ||
| UIApplication.shared.open(url) |
There was a problem hiding this comment.
maybe check if canOpen url also?
rnr
approved these changes
Jul 24, 2024
shafqat-muneer
requested changes
Jul 25, 2024
Comment on lines
95
to
97
| guard let chapterIndex = chapterIndex else { return } | ||
| guard let sequentialIndex else { return } | ||
| guard let courseVertical = sequential.childs.first else { return } |
There was a problem hiding this comment.
Should we also display any toast error messages to the user in these possible cases?
There was a problem hiding this comment.
We will he handing gated content properly post MVP, so we will look into it as well.
rnr
pushed a commit
that referenced
this pull request
Oct 28, 2024
rnr
added a commit
that referenced
this pull request
Nov 4, 2024
* chore: show unsupported error screen for gated content (#37) * chore: string auto-generating * chore: removed unused func * chore: update facebook sdk to solve open(url) issue --------- Co-authored-by: Saeed Bashir <[email protected]> Co-authored-by: Anton Yarmolenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the following Issue