Skip to content

fix: Course mode is used to show the correct bulk email options - #172

Closed
Inferato wants to merge 2 commits into
openedx:open-release/quince.masterfrom
Inferato:lytvynenko/bulk_email_checkbox_quince
Closed

fix: Course mode is used to show the correct bulk email options#172
Inferato wants to merge 2 commits into
openedx:open-release/quince.masterfrom
Inferato:lytvynenko/bulk_email_checkbox_quince

Conversation

@Inferato

@Inferato Inferato commented Nov 9, 2023

Copy link
Copy Markdown
Contributor

Description

This is a backport MR to the master branch.

According to the chapter Sending Email Messages to Learners in Different Enrollment Tracks course can may more than one mode and instructor must have the ability to send the email for users in this modes.
Communication MFE had a hardcoded 2 modes for every course. Sometimes it lead to the error.
изображение

courseModes was added to courseMetadata to display real course email recipient options.

Related MR:

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 9, 2023
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov

codecov Bot commented Nov 9, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@3e7ea6a). Click here to learn what that means.

❗ Current head f48148e differs from pull request most recent head a65d932. Consider uploading reports for the commit a65d932 to get more accurate results

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #172   +/-   ##
=============================================================
  Coverage                              ?   83.18%           
=============================================================
  Files                                 ?       47           
  Lines                                 ?      690           
  Branches                              ?      135           
=============================================================
  Hits                                  ?      574           
  Misses                                ?      116           
  Partials                              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arbrandes

Copy link
Copy Markdown
Contributor

Isn't this the same as #171?

@mariajgrimaldi

Copy link
Copy Markdown
Member

@arbrandes: it looks like it, but this is the backport PR

@cmltaWt0 cmltaWt0 added the product review PR requires product review before merging label Feb 6, 2024
@dyudyunov

Copy link
Copy Markdown
Contributor

This PR should be closed in favor of #192. The only difference compared to the current PR is that I applied Adolfo's suggestions from the master PR

@mariajgrimaldi @arbrandes @cmltaWt0 FYI

@cmltaWt0

cmltaWt0 commented Feb 7, 2024

Copy link
Copy Markdown

Got it. Would you mind adding the same description to the new PR?
I will close this by the end of the day if there are no objections.

@dyudyunov

Copy link
Copy Markdown
Contributor

Got it. Would you mind adding the same description to the new PR? I will close this by the end of the day if there are no objections.

Ok, but I would rather copy the description from the related master PR #191

@cmltaWt0 cmltaWt0 removed the product review PR requires product review before merging label Feb 8, 2024
@cmltaWt0 cmltaWt0 closed this Feb 8, 2024
@openedx-webhooks

Copy link
Copy Markdown

@Inferato Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants