Skip to content

fix: hardcoded course mode checkboxes - #192

Merged
arbrandes merged 3 commits into
openedx:open-release/quince.masterfrom
dyudyunov:lytvynenko/bulk_email_checkbox_quince
Feb 27, 2024
Merged

fix: hardcoded course mode checkboxes#192
arbrandes merged 3 commits into
openedx:open-release/quince.masterfrom
dyudyunov:lytvynenko/bulk_email_checkbox_quince

Conversation

@dyudyunov

@dyudyunov dyudyunov commented Feb 7, 2024

Copy link
Copy Markdown
Contributor

This is a backport of #191

The Communication MFE has course mode checkboxes hardcoded, so a user can select any of them even if the course has no such mode.
As a result - they will get an error when trying to send emails to learners of the track (course mode) that doesn't exist.
image
image

The goal here is to provide course mode checkboxes for real course modes only.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @dyudyunov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@codecov

codecov Bot commented Feb 7, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (open-release/quince.master@3e7ea6a). Click here to learn what that means.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             open-release/quince.master     #192   +/-   ##
=============================================================
  Coverage                              ?   83.23%           
=============================================================
  Files                                 ?       47           
  Lines                                 ?      692           
  Branches                              ?      135           
=============================================================
  Hits                                  ?      576           
  Misses                                ?      116           
  Partials                              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Feb 7, 2024
@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Feb 21, 2024
@arbrandes
arbrandes merged commit eae2037 into openedx:open-release/quince.master Feb 27, 2024
@openedx-webhooks

Copy link
Copy Markdown

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@dyudyunov
dyudyunov deleted the lytvynenko/bulk_email_checkbox_quince branch February 28, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants