fix: course mode added to the metadata

[Inferato]

Description

According to the chapter Sending Email Messages to Learners in Different Enrollment Tracks course can may more than one mode and instructor must have the ability to send the email for users in this modes.
Communication MFE had a hardcoded 2 modes for every course. Sometimes it lead to the error.

courseModes was added to courseMetadata to display real course email recipient options.

Related MR:

• frontend-app-communications/open-release/quince.master
• frontend-app-communications/master
• edx-platform/open-release/quince.master

Deadline

None

[openedx-webhooks]

Thanks for the pull request, @Inferato! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

• supporting documentation
• Open edX discussion forum threads
• timeline information ("this must be merged by XX date", and why that is)
• partner information ("this is a course on edx.org")
• any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

[mariajgrimaldi]

Hi there @dyudyunov! Regarding your comment here, is this something you folks are still going to pursue?

[dyudyunov]

Hi there @dyudyunov! Regarding your comment here, is this something you folks are still going to pursue?

Hi @mariajgrimaldi

I'll find time to search and inspect all the PRs Taras has made.
I will leave status update comments on each of them

[mariajgrimaldi]

Sorry for all the pings. Thank you @dyudyunov!

[dyudyunov]

Hi there @mariajgrimaldi

I checked this fix and it is actual.

I would like to add a bit more context to the problem.

The Communication MFE has course mode checkboxes hardcoded, so a user can select any of them even if the course has no such mode.
As a result - they will get an error when trying to send emails to learners of the track (course mode) that doesn't exist.

The goal here is to provide course mode checkboxes for real course modes only.

---

This PR seems to be ready for the review.
I will update the related PR to the Communications MFE with Adolfo's suggestions soon, but this one could be reviewed/merged independently.

[dyudyunov]

I can't update Taras' source branch, so I created a new related PR to the Communications MFE. It consists of the original commits plus Adolfo's suggestions applied in a separate one.

openedx/frontend-app-communications#191

[mariajgrimaldi]

I understand this is a fix of the current behavior, but since this changes how the communications MFE behaves I added the product review label.

cc @dyudyunov @mphilbrick211

[dyudyunov]

@mariajgrimaldi hi!

Related PR to the Communications MFE was just merged, but it requires this one to work properly

Is it possible to prioritize this PR to avoid problems with the Communications MFE?

@arbrandes this is my fault, I mentioned the related Communications MFE PR here but forgot to add the note about the dependency in the Communications MFE PR

[arbrandes]

This change makes sense, and as @dyudyunov put it, it is required for the Communications MFE to work as it stands in master now.

I submit that this is actually a bug fix, so no product review required.

I'm not a CC here so can't approve. @kdmccormick or @feanil, any objections to merging it?

[feanil]

Looks good to me, it's adding more data to an existing API endpoint and the lookup should be pretty cheap so not a performance concern either.

[feanil]

@dyudyunov should I go ahead and merge this or are there any reasons to hold-off?

[dyudyunov]

@feanil hi

Yes, it's ready for merge
Please check the Quince backport too #33691

[openedx-webhooks]

@Inferato 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

[edx-pipeline-bot]

2U Release Notice: This PR has been deployed to the edX production environment.